chatterino2
Code Issues

Add showInMentions option for Badge Highlights (#4034)

Browse Source 
Co-authored-by: Rasmus Karlsson <rasmus.karlsson@pajlada.com>
This commit is contained in:
Felanbird
2022-10-02 07:25:10 -04:00
committed by GitHub
parent 2deed8e1cb
commit 9816722b5e
8 changed files with 97 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/src/HighlightController.cpp
+38 -1
View File
@@ -367,6 +367,15 @@ static QString DEFAULT_SETTINGS = R"!(
"sound": false,
"soundUrl": "",
"color": "#7fe8b7eb"
},
{
"name": "vip",
"displayName": "VIP",
"showInMentions": true,
"alert": false,
"sound": false,
"soundUrl": "",
"color": "#7fe8b7ec"
}
],
"subHighlightColor": "#64ffd641"
@@ -530,6 +539,32 @@ TEST_F(HighlightControllerTest, A)
},
},
},
{
// Badge highlight with showInMentions only
{
// input
MessageParseArgs{}, // no special args
{
{
"vip",
"0",
},
},
"badge", // sender name
"show in mentions only", // original message
},
{
// expected
true, // state
{
false, // alert
false, // playsound
boost::none, // custom sound url
std::make_shared<QColor>("#7fe8b7ec"), // color
true, // showInMentions
},
},
},
{
// User mention with showInMentions
{
@@ -602,6 +637,8 @@ TEST_F(HighlightControllerTest, A)
EXPECT_EQ(isMatch, expected.state)
<< qUtf8Printable(input.senderName) << ": "
<< qUtf8Printable(input.originalMessage);
EXPECT_EQ(matchResult, expected.result);
EXPECT_EQ(matchResult, expected.result)
<< qUtf8Printable(input.senderName) << ": "
<< qUtf8Printable(input.originalMessage);
}
}