refactor(eventsub): more references, less const (#5953)

lib/twitch-eventsub-ws/benchmarks/src/parse.cpp

@@ -14,7 +14,8 @@ using namespace chatterino::eventsub::lib;
 std::vector<boost::beast::flat_buffer> readMessages()
 {
     QFile file(":/bench/messages.ndjson");
-    assert(file.open(QFile::ReadOnly));
+    bool ok = file.open(QFile::ReadOnly);
+    assert(ok);
 
     std::vector<boost::beast::flat_buffer> messages;
     while (!file.atEnd())
@@ -41,67 +42,71 @@ public:
     NoopListener() = default;
 
     // NOLINTBEGIN(cppcoreguidelines-pro-type-const-cast)
-    void onSessionWelcome(messages::Metadata metadata,
-                          payload::session_welcome::Payload payload) override
+    void onSessionWelcome(
+        const messages::Metadata &metadata,
+        const payload::session_welcome::Payload &payload) override
     {
         benchmark::DoNotOptimize(&metadata);
         benchmark::DoNotOptimize(&payload);
     }
 
-    void onNotification(messages::Metadata metadata,
+    void onNotification(const messages::Metadata &metadata,
                         const boost::json::value &jv) override
     {
         benchmark::DoNotOptimize(&metadata);
         benchmark::DoNotOptimize(&jv);
     }
 
-    void onChannelBan(messages::Metadata metadata,
-                      payload::channel_ban::v1::Payload payload) override
+    void onChannelBan(const messages::Metadata &metadata,
+                      const payload::channel_ban::v1::Payload &payload) override
     {
         benchmark::DoNotOptimize(&metadata);
         benchmark::DoNotOptimize(&payload);
     }
 
-    void onStreamOnline(messages::Metadata metadata,
-                        payload::stream_online::v1::Payload payload) override
+    void onStreamOnline(
+        const messages::Metadata &metadata,
+        const payload::stream_online::v1::Payload &payload) override
     {
         benchmark::DoNotOptimize(&metadata);
         benchmark::DoNotOptimize(&payload);
     }
 
-    void onStreamOffline(messages::Metadata metadata,
-                         payload::stream_offline::v1::Payload payload) override
+    void onStreamOffline(
+        const messages::Metadata &metadata,
+        const payload::stream_offline::v1::Payload &payload) override
     {
         benchmark::DoNotOptimize(&metadata);
         benchmark::DoNotOptimize(&payload);
     }
 
     void onChannelChatNotification(
-        messages::Metadata metadata,
-        payload::channel_chat_notification::v1::Payload payload) override
+        const messages::Metadata &metadata,
+        const payload::channel_chat_notification::v1::Payload &payload) override
     {
         benchmark::DoNotOptimize(&metadata);
         benchmark::DoNotOptimize(&payload);
     }
 
-    void onChannelUpdate(messages::Metadata metadata,
-                         payload::channel_update::v1::Payload payload) override
+    void onChannelUpdate(
+        const messages::Metadata &metadata,
+        const payload::channel_update::v1::Payload &payload) override
     {
         benchmark::DoNotOptimize(&metadata);
         benchmark::DoNotOptimize(&payload);
     }
 
     void onChannelChatMessage(
-        messages::Metadata metadata,
-        payload::channel_chat_message::v1::Payload payload) override
+        const messages::Metadata &metadata,
+        const payload::channel_chat_message::v1::Payload &payload) override
     {
         benchmark::DoNotOptimize(&metadata);
         benchmark::DoNotOptimize(&payload);
     }
 
     void onChannelModerate(
-        messages::Metadata metadata,
-        payload::channel_moderate::v2::Payload payload) override
+        const messages::Metadata &metadata,
+        const payload::channel_moderate::v2::Payload &payload) override
     {
         benchmark::DoNotOptimize(&metadata);
         benchmark::DoNotOptimize(&payload);