Fix crash that could occur when closing a split before its display name was updated (#4731)
This fixes a crash that could occur when closing a split before the display name had a chance to update The reason I found this was because the LiveController change I made updated display names more regularly Additionally, we now make sure to not send duplicate `displayNameUpdated` signals upon each request for channels with CJK characters in their display name * Default-initialize the `actualDisplayName` with the user's login name to not send an initial display name update if the display name is the same casing as the login name
This commit is contained in:
@@ -229,8 +229,17 @@ public:
|
||||
|
||||
private:
|
||||
struct NameOptions {
|
||||
// displayName is the non-CJK-display name for this user
|
||||
// This will always be the same as their `name_`, but potentially with different casing
|
||||
QString displayName;
|
||||
|
||||
// localizedName is their display name that *may* contain CJK characters
|
||||
// If the display name does not contain any CJK characters, this will be
|
||||
// the same as `displayName`
|
||||
QString localizedName;
|
||||
|
||||
// actualDisplayName is the raw display name string received from Twitch
|
||||
QString actualDisplayName;
|
||||
} nameOptions;
|
||||
|
||||
private:
|
||||
|
||||
Reference in New Issue
Block a user