chatterino2
Code Issues

Fix crash that could occur when closing a split before its display name was updated (#4731)

Browse Source 
This fixes a crash that could occur when closing a split before the
display name had a chance to update

The reason I found this was because the LiveController change I made
updated display names more regularly

Additionally, we now make sure to not send duplicate `displayNameUpdated` signals
upon each request for channels with CJK characters in their display name

* Default-initialize the `actualDisplayName` with the user's login name to not send an initial display name update if the display name is the same casing as the login name
This commit is contained in:
pajlada
2023-07-23 12:11:57 +02:00
committed by GitHub
parent 5c8c05b1af
commit a440f0261a
5 changed files with 22 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/widgets/splits/Split.cpp
+4 -3
View File
@@ -850,9 +850,10 @@ void Split::setChannel(IndirectChannel newChannel)
this->header_->setViewersButtonVisible(false);
}
this->channel_.get()->displayNameChanged.connect([this] {
this->actionRequested.invoke(Action::RefreshTab);
});
this->channelSignalHolder_.managedConnect(
this->channel_.get()->displayNameChanged, [this] {
this->actionRequested.invoke(Action::RefreshTab);
});
this->channelChanged.invoke();
this->actionRequested.invoke(Action::RefreshTab);