feat: add setting to search in incognito mode (#6770)
Reviewed-by: pajlada <rasmus.karlsson@pajlada.com>
This commit is contained in:
+1
-1
@@ -2,7 +2,7 @@
|
|||||||
|
|
||||||
## Unversioned
|
## Unversioned
|
||||||
|
|
||||||
- Minor: Add search engine selection for context menu search action. (#6743)
|
- Minor: Add search engine selection for context menu search action. (#6743, #6770)
|
||||||
- Minor: Add a separate highlight option for watchstreak notifications. (#6571, #6581)
|
- Minor: Add a separate highlight option for watchstreak notifications. (#6571, #6581)
|
||||||
- Minor: Badges now link to their home page like emotes in the context menu. (#6437)
|
- Minor: Badges now link to their home page like emotes in the context menu. (#6437)
|
||||||
- Minor: Fixed usercard resizing improperly without recent messages. (#6496)
|
- Minor: Fixed usercard resizing improperly without recent messages. (#6496)
|
||||||
|
|||||||
@@ -325,6 +325,10 @@ public:
|
|||||||
"/behaviour/search/engineName",
|
"/behaviour/search/engineName",
|
||||||
"",
|
"",
|
||||||
};
|
};
|
||||||
|
BoolSetting searchIncognito = {
|
||||||
|
"/behaviour/search/incognito",
|
||||||
|
false,
|
||||||
|
};
|
||||||
|
|
||||||
EnumSetting<UsernameRightClickBehavior> usernameRightClickBehavior = {
|
EnumSetting<UsernameRightClickBehavior> usernameRightClickBehavior = {
|
||||||
"/behaviour/usernameRightClickBehavior",
|
"/behaviour/usernameRightClickBehavior",
|
||||||
|
|||||||
@@ -2722,10 +2722,24 @@ void ChannelView::addMessageContextMenuItems(QMenu *menu,
|
|||||||
QString actionText =
|
QString actionText =
|
||||||
searchName.isEmpty() ? "&Search" : "&Search with " + searchName;
|
searchName.isEmpty() ? "&Search" : "&Search with " + searchName;
|
||||||
|
|
||||||
|
if (getSettings()->searchIncognito && supportsIncognitoLinks())
|
||||||
|
{
|
||||||
|
actionText += " in private mode";
|
||||||
|
}
|
||||||
|
|
||||||
menu->addAction(actionText, [this, searchURL] {
|
menu->addAction(actionText, [this, searchURL] {
|
||||||
QString query = this->getSelectedText().trimmed();
|
QString query = this->getSelectedText().trimmed();
|
||||||
QString encodedQuery = QUrl::toPercentEncoding(query);
|
QString encodedQuery = QUrl::toPercentEncoding(query);
|
||||||
QDesktopServices::openUrl(QUrl(searchURL + encodedQuery));
|
QString url = searchURL + encodedQuery;
|
||||||
|
|
||||||
|
if (getSettings()->searchIncognito && supportsIncognitoLinks())
|
||||||
|
{
|
||||||
|
openLinkIncognito(url);
|
||||||
|
}
|
||||||
|
else
|
||||||
|
{
|
||||||
|
QDesktopServices::openUrl(QUrl(url));
|
||||||
|
}
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1284,6 +1284,13 @@ void GeneralPage::initLayout(GeneralPageView &layout)
|
|||||||
->conditionallyEnabledBy(s.searchEnabled)
|
->conditionallyEnabledBy(s.searchEnabled)
|
||||||
->addTo(layout);
|
->addTo(layout);
|
||||||
}
|
}
|
||||||
|
if (supportsIncognitoLinks())
|
||||||
|
{
|
||||||
|
SettingWidget::checkbox("Search in incognito/private mode",
|
||||||
|
s.searchIncognito)
|
||||||
|
->addTo(layout);
|
||||||
|
}
|
||||||
|
|
||||||
layout.addSubtitle("Miscellaneous");
|
layout.addSubtitle("Miscellaneous");
|
||||||
|
|
||||||
if (supportsIncognitoLinks())
|
if (supportsIncognitoLinks())
|
||||||
|
|||||||
Reference in New Issue
Block a user