fix: ensure liveupdate pubsubs exit (#5557)

Previously, the derived class (i.e. BttvLiveUpdates or SeventvEventAPI)
    would have their destructor ran before BasicPubSubManager called
    stop, meaning there was a time wherein messages could still flow
    through, attempting to call `onMessage` on a pure virtual, causing a
    crash.
This commit is contained in:
pajlada
2024-08-24 14:01:13 +02:00
committed by GitHub
parent 175afa8b16
commit aa048b3793
7 changed files with 34 additions and 6 deletions
+5
View File
@@ -15,6 +15,11 @@ BttvLiveUpdates::BttvLiveUpdates(QString host)
{
}
BttvLiveUpdates::~BttvLiveUpdates()
{
this->stop();
}
void BttvLiveUpdates::joinChannel(const QString &channelID,
const QString &userName)
{
+1
View File
@@ -19,6 +19,7 @@ class BttvLiveUpdates : public BasicPubSubManager<BttvLiveUpdateSubscription>
public:
BttvLiveUpdates(QString host);
~BttvLiveUpdates() override;
struct {
Signal<BttvLiveUpdateEmoteUpdateAddMessage> emoteAdded;