chatterino2
Code Issues

Get rid of dynamic_cast

Browse Source
This commit is contained in:
rexim
2019-05-22 00:33:12 +07:00
parent cbb1ec2d7a
commit aa4e7f13e7
3 changed files with 20 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/messages/layouts/MessageLayoutElement.cpp
+11
View File
@@ -296,6 +296,11 @@ int TextLayoutElement::getXFromIndex(int index)
}
}
boost::optional<QPixmap> TextLayoutElement::pixmap() const
{
return boost::none;
}
// TEXT ICON
TextIconLayoutElement::TextIconLayoutElement(MessageElement &creator,
const QString &_line1,
@@ -373,4 +378,10 @@ int TextIconLayoutElement::getXFromIndex(int index)
}
}
boost::optional<QPixmap> TextIconLayoutElement::pixmap() const
{
return boost::none;
}
} // namespace chatterino
src/messages/layouts/MessageLayoutElement.hpp
+5 -2
View File
@@ -41,6 +41,8 @@ public:
virtual void paintAnimated(QPainter &painter, int yOffset) = 0;
virtual int getMouseOverIndex(const QPoint &abs) const = 0;
virtual int getXFromIndex(int index) = 0;
virtual boost::optional<QPixmap> pixmap() const = 0;
const Link &getLink() const;
const QString &getText() const;
FlagsEnum<MessageElementFlag> getFlags() const;
@@ -62,8 +64,6 @@ public:
ImageLayoutElement(MessageElement &creator, ImagePtr image,
const QSize &size);
boost::optional<QPixmap> pixmap() const;
protected:
void addCopyTextToString(QString &str, int from = 0,
int to = INT_MAX) const override;
@@ -72,6 +72,7 @@ protected:
void paintAnimated(QPainter &painter, int yOffset) override;
int getMouseOverIndex(const QPoint &abs) const override;
int getXFromIndex(int index) override;
boost::optional<QPixmap> pixmap() const override;
private:
ImagePtr image_;
@@ -95,6 +96,7 @@ protected:
void paintAnimated(QPainter &painter, int yOffset) override;
int getMouseOverIndex(const QPoint &abs) const override;
int getXFromIndex(int index) override;
boost::optional<QPixmap> pixmap() const override;
private:
QColor color_;
@@ -120,6 +122,7 @@ protected:
void paintAnimated(QPainter &painter, int yOffset) override;
int getMouseOverIndex(const QPoint &abs) const override;
int getXFromIndex(int index) override;
boost::optional<QPixmap> pixmap() const override;
private:
float scale;