Harden emote parsing (#3885)

2022-11-05 11:04:35 +01:00
parent f00f766eeb
commit aac9ea53d0
14 changed files with 1163 additions and 104 deletions
@@ -38,10 +38,10 @@ public:
    SignalVector(std::function<bool(const T &, const T &)> &&compare)
        : SignalVector()
    {
-        itemCompare_ = std::move(compare);
+        this->itemCompare_ = std::move(compare);
    }

-    virtual bool isSorted() const
+    bool isSorted() const
    {
        return bool(this->itemCompare_);
    }
@@ -76,9 +76,13 @@ public:
        else
        {
            if (index == -1)
+            {
                index = this->items_.size();
+            }
            else
+            {
                assert(index >= 0 && index <= this->items_.size());
+            }

            this->items_.insert(this->items_.begin() + index, item);
        }