From adf58d2770c8d6894bebcbb3c2435279493bd385 Mon Sep 17 00:00:00 2001 From: pajlada Date: Thu, 26 Jan 2023 19:47:32 +0100 Subject: [PATCH] Clean up clang-tidy action checks (#4331) * clang-tidy action: Exclude lib & tests dir for clang-tidy CI checks The lib dir is obvious, but the tests dir is disabled because gtest has a million different thing that clang-tidy doesn't like, while they're in reality perfectly reasonable * clang-tidy-action: Disable the LGTM comment --- .github/workflows/build.yml | 1 + .github/workflows/post-clang-tidy-review.yml | 2 ++ 2 files changed, 3 insertions(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 3be221c5..83a19279 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -166,6 +166,7 @@ jobs: build_dir: build config_file: ".clang-tidy" split_workflow: true + exclude: "tests/*,lib/*" - uses: actions/upload-artifact@v3 if: (startsWith(matrix.os, 'ubuntu') && matrix.pch == false && matrix.qt-version == '5.15.2' && github.event_name == 'pull_request') diff --git a/.github/workflows/post-clang-tidy-review.yml b/.github/workflows/post-clang-tidy-review.yml index cd02e593..6d8f733e 100644 --- a/.github/workflows/post-clang-tidy-review.yml +++ b/.github/workflows/post-clang-tidy-review.yml @@ -37,3 +37,5 @@ jobs: - uses: ZedThree/clang-tidy-review/post@v0.10.1 id: review + with: + lgtm_comment_body: ""