Make use of QUrlQuery in NetworkRequests where it was hardcoded into url (#3039)

Co-authored-by: Rasmus Karlsson <rasmus.karlsson@pajlada.com>

src/providers/twitch/TwitchBadges.cpp

@@ -7,6 +7,7 @@
 #include <QJsonObject>
 #include <QJsonValue>
 #include <QThread>
+#include <QUrlQuery>
 
 #include "common/NetworkRequest.hpp"
 #include "common/Outcome.hpp"
@@ -24,8 +25,11 @@ void TwitchBadges::loadTwitchBadges()
 {
     assert(this->loaded_ == false);
 
-    static QString url(
+    QUrl url("https://badges.twitch.tv/v1/badges/global/display");
-        "https://badges.twitch.tv/v1/badges/global/display?language=en");
+
+    QUrlQuery urlQuery;
+    urlQuery.addQueryItem("language", "en");
+    url.setQuery(urlQuery);
 
     NetworkRequest(url)
         .onSuccess([this](auto result) -> Outcome {

src/providers/twitch/TwitchChannel.cpp

@@ -755,11 +755,14 @@ void TwitchChannel::loadRecentMessages()
         return;
     }
 
-    auto baseURL = Env::get().recentMessagesApiUrl.arg(this->getName());
+    QUrl url(Env::get().recentMessagesApiUrl.arg(this->getName()));
-
+    QUrlQuery urlQuery(url);
-    auto url = QString("%1?limit=%2")
+    if (!urlQuery.hasQueryItem("limit"))
-                   .arg(baseURL)
+    {
-                   .arg(getSettings()->twitchMessageHistoryLimit);
+        urlQuery.addQueryItem(
+            "limit", QString::number(getSettings()->twitchMessageHistoryLimit));
+    }
+    url.setQuery(urlQuery);
 
     auto weak = weakOf<Channel>(this);