chatterino2
Code Issues

fix: orphan FramelessDraggables too (#5576)

Browse Source
This commit is contained in:
nerix
2024-08-31 11:16:17 +02:00
committed by GitHub
parent cda8fa2a65
commit af309b726f
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CHANGELOG.md
+1 -1
View File
@@ -35,7 +35,7 @@
- Bugfix: Fixed a crash when tab completing while having an invalid plugin loaded. (#5401) - Bugfix: Fixed a crash when tab completing while having an invalid plugin loaded. (#5401)
- Bugfix: Fixed windows on Windows not saving correctly when snapping them to the edges. (#5478) - Bugfix: Fixed windows on Windows not saving correctly when snapping them to the edges. (#5478)
- Bugfix: Fixed user info card popups adding duplicate line to log files. (#5499) - Bugfix: Fixed user info card popups adding duplicate line to log files. (#5499)
- Bugfix: Fixed tooltips and input completion popups not working after moving a split. (#5541) - Bugfix: Fixed tooltips and input completion popups not working after moving a split. (#5541, #5576)
- Bugfix: Fixed rare issue on shutdown where the client would hang. (#5557) - Bugfix: Fixed rare issue on shutdown where the client would hang. (#5557)
- Bugfix: Fixed `/clearmessages` not working with more than one window. (#5489) - Bugfix: Fixed `/clearmessages` not working with more than one window. (#5489)
- Bugfix: Fixed splits staying paused after unfocusing Chatterino in certain configurations. (#5504) - Bugfix: Fixed splits staying paused after unfocusing Chatterino in certain configurations. (#5504)
src/widgets/BaseWindow.cpp
+1 -1
View File
@@ -505,7 +505,7 @@ bool BaseWindow::event(QEvent *event)
} }
#if QT_VERSION >= QT_VERSION_CHECK(6, 7, 0) #if QT_VERSION >= QT_VERSION_CHECK(6, 7, 0)
if (this->flags_.has(DontFocus) || this->flags_.has(Dialog)) if (this->flags_.hasAny(DontFocus, Dialog, FramelessDraggable))
{ {
// This certain windows (e.g. TooltipWidget, input completion widget, and the search popup) retains their nullptr parent // This certain windows (e.g. TooltipWidget, input completion widget, and the search popup) retains their nullptr parent
// NOTE that this currently does not retain their original transient parent (which is the window it was created under) // NOTE that this currently does not retain their original transient parent (which is the window it was created under)