From af573484c41d1db37014567b6dde054b11e32e5c Mon Sep 17 00:00:00 2001 From: SonicSegFault <81888555+SonicSegFault@users.noreply.github.com> Date: Sat, 10 Jan 2026 18:06:09 +0530 Subject: [PATCH] fix: percent-encoded url for custom players (#6725) Reviewed-by: Rasmus Karlsson --- CHANGELOG.md | 1 + src/util/CustomPlayer.cpp | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 21fa21ff..26693087 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -36,6 +36,7 @@ - Bugfix: Forward query params to websocket URLs. (#6141) - Bugfix: Fixed Lua errors from handlers of HTTP requests not being logged. (#6452) - Bugfix: Fixed restore button not showing on Windows. (#6565) +- Bugfix: Fixed custom player URIs for external players not always working due to URL percent-encoding. (#6725) - Bugfix: Fixed a crash that could occur when network requests were loading/saving cache as Chatterino was being shut down. (#6698) - Bugfix: Fixed popups and the overlay not being draggable on Wayland. (#6573) - Bugfix: Fixed middle-clicking usernames in a local channel opening an invalid viewercard. (#6577) diff --git a/src/util/CustomPlayer.cpp b/src/util/CustomPlayer.cpp index 3cc0c221..a8259f5b 100644 --- a/src/util/CustomPlayer.cpp +++ b/src/util/CustomPlayer.cpp @@ -25,8 +25,9 @@ void openInCustomPlayer(QStringView channelName) return; } - QDesktopServices::openUrl( - QUrl{scheme % u"https://www.twitch.tv/" % channelName}); + QString encodedTwitchUrl = QString::fromUtf8( + QUrl::toPercentEncoding(u"https://www.twitch.tv/" % channelName)); + QDesktopServices::openUrl(QUrl{scheme % encodedTwitchUrl}); } } // namespace chatterino