Changelog crash fix (macOS) (#1935)

On macOS, trying to display a dialog before showing the main window
(like when starting minimized) leads to a crash. The dialog will now
show before the main window is opened, preventing this issue.
This commit is contained in:
Daniel
2020-09-06 06:02:15 -04:00
committed by GitHub
parent caf0023327
commit b024b47afd
4 changed files with 19 additions and 30 deletions
-29
View File
@@ -119,35 +119,6 @@ bool Window::event(QEvent *event)
return BaseWindow::event(event);
}
void Window::showEvent(QShowEvent *event)
{
// Startup notification
/*if (getSettings()->startUpNotification.getValue() < 1)
{
getSettings()->startUpNotification = 1;
}*/
// Show changelog
if (getSettings()->currentVersion.getValue() != "" &&
getSettings()->currentVersion.getValue() != CHATTERINO_VERSION)
{
auto box = new QMessageBox(QMessageBox::Information, "Chatterino 2",
"Show changelog?",
QMessageBox::Yes | QMessageBox::No);
box->setAttribute(Qt::WA_DeleteOnClose);
if (box->exec() == QMessageBox::Yes)
{
QDesktopServices::openUrl(
QUrl("https://www.chatterino.com/changelog"));
}
}
getSettings()->currentVersion.setValue(CHATTERINO_VERSION);
// --
BaseWindow::showEvent(event);
}
void Window::closeEvent(QCloseEvent *)
{
if (this->type_ == WindowType::Main)