Fix warnings that occured on linux using clang

This commit is contained in:
Rasmus Karlsson
2018-04-14 21:59:51 +02:00
parent 57e788422f
commit b7266b1640
21 changed files with 47 additions and 46 deletions
+1 -1
View File
@@ -105,7 +105,7 @@ void EmotePopup::loadEmojis()
builder.getMessage()->flags &= Message::Centered;
builder.getMessage()->flags &= Message::DisableCompactEmotes;
emojis.each([this, &builder](const QString &key, const auto &value) {
emojis.each([&builder](const QString &key, const auto &value) {
builder.append((new EmoteElement(value.emoteData, MessageElement::Flags::AlwaysShow))
->setLink(Link(Link::Type::InsertText, ":" + value.shortCode + ":")));
});
+1 -1
View File
@@ -63,7 +63,7 @@ NotebookTab::NotebookTab(Notebook *_notebook)
this->menu.addAction(enableHighlightsOnNewMessageAction);
QObject::connect(enableHighlightsOnNewMessageAction, &QAction::toggled, [this](bool newValue) {
QObject::connect(enableHighlightsOnNewMessageAction, &QAction::toggled, [](bool newValue) {
debug::Log("New value is {}", newValue); //
});
}
-2
View File
@@ -43,8 +43,6 @@ void QualityPopup::okButtonClicked()
{
QString channelURL = "twitch.tv/" + this->channelName;
singletons::SettingManager &settings = singletons::SettingManager::getInstance();
try {
streamlink::OpenStreamlink(channelURL, this->ui.selector.currentText());
} catch (const streamlink::Exception &ex) {
+2 -6
View File
@@ -1,17 +1,13 @@
#pragma once
#include "basewindow.hpp"
#include <QComboBox>
#include <QDialogButtonBox>
#include <QHBoxLayout>
#include <QPushButton>
#include <QVBoxLayout>
#include <QWidget>
#include "basewindow.hpp"
#include "singletons/settingsmanager.hpp"
namespace chatterino {
namespace widgets {
class QualityPopup : public BaseWindow
+1 -1
View File
@@ -24,7 +24,7 @@ AccountsPage::AccountsPage()
this->removeButton = buttons->addButton("Remove", QDialogButtonBox::NoRole);
}
auto accountSwitch = layout.emplace<AccountSwitchWidget>(this).assign(&this->accSwitchWidget);
layout.emplace<AccountSwitchWidget>(this).assign(&this->accSwitchWidget);
// ----
QObject::connect(this->addButton, &QPushButton::clicked, []() {
@@ -45,10 +45,13 @@ IgnoreUsersPage::IgnoreUsersPage()
{
auto add = addremove.emplace<QPushButton>("Ignore user");
auto remove = addremove.emplace<QPushButton>("Unignore User");
UNUSED(add); // TODO: Add on-clicked event
UNUSED(remove); // TODO: Add on-clicked event
addremove->addStretch(1);
}
auto userList = group.emplace<QListView>();
UNUSED(userList); // TODO: Fill this list in with ignored users
}
}
+2
View File
@@ -19,7 +19,9 @@ public:
StreamView(std::shared_ptr<Channel> channel, const QUrl &url);
private:
#ifdef USEWEBENGINE
QWebEngineView *stream;
#endif
};
} // namespace widgets
+2 -2
View File
@@ -37,11 +37,11 @@ Window::Window(singletons::ThemeManager &_themeManager, WindowType _type)
this->addTitleBarButton(TitleBarButton::Settings, [] {
singletons::WindowManager::getInstance().showSettingsDialog();
});
auto user = this->addTitleBarLabel([this] {
auto user = this->addTitleBarLabel([] {
singletons::WindowManager::getInstance().showAccountSelectPopup(QCursor::pos());
});
singletons::AccountManager::getInstance().Twitch.userChanged.connect([this, user] {
singletons::AccountManager::getInstance().Twitch.userChanged.connect([user] {
user->getLabel().setText(
singletons::AccountManager::getInstance().Twitch.getCurrent()->getUserName());
});