Fix: tabs move animation for duplicated tabs (#5426)
* fix: check endValue for running animations only * exit early when move is not needed * ref: remove useless `positionChangedAnimationRunning_` * check for parent notebook visibility instead * ref: rename `pos` param to `targetPos`
This commit is contained in:
@@ -65,7 +65,7 @@ public:
|
||||
void setHighlightsEnabled(const bool &newVal);
|
||||
bool hasHighlightsEnabled() const;
|
||||
|
||||
void moveAnimated(QPoint pos, bool animated = true);
|
||||
void moveAnimated(QPoint targetPos, bool animated = true);
|
||||
|
||||
QRect getDesiredRect() const;
|
||||
void hideTabXChanged();
|
||||
@@ -108,7 +108,6 @@ private:
|
||||
int normalTabWidthForHeight(int height) const;
|
||||
|
||||
QPropertyAnimation positionChangedAnimation_;
|
||||
bool positionChangedAnimationRunning_ = false;
|
||||
QPoint positionAnimationDesiredPoint_;
|
||||
|
||||
Notebook *notebook_;
|
||||
|
||||
Reference in New Issue
Block a user