streamlink: trim custom paths (#4834)

this makes sure no spaces are accidentally left in the custom path

Co-authored-by: Rasmus Karlsson <rasmus.karlsson@pajlada.com>

CHANGELOG.md

@@ -5,6 +5,7 @@
 - Minor: Migrate to the new Get Channel Followers Helix endpoint, fixing follower count not showing up in usercards. (#4809)
 - Minor: The account switcher is now styled to match your theme. (#4817)
 - Minor: Add an invisible resize handle to the bottom of frameless user info popups and reply thread popups. (#4795)
+- Bugfix: Trimmed custom streamlink paths on all platforms making sure you don't accidentally add spaces at the beginning or end of its path. (#4834)
 - Bugfix: Fixed a performance issue when displaying replies to certain messages. (#4807)
 - Bugfix: Fixed a data race when disconnecting from Twitch PubSub. (#4771)
 - Bugfix: Fixed `/shoutout` command not working with usernames starting with @'s (e.g. `/shoutout @forsen`). (#4800)

src/util/StreamLink.cpp

@@ -75,17 +75,16 @@ namespace {
 
     QProcess *createStreamlinkProcess()
     {
-        auto p = new QProcess;
+        auto *p = new QProcess;
 
-        const QString path = [] {
+        const QString path = []() -> QString {
             if (getSettings()->streamlinkUseCustomPath)
             {
-                return getSettings()->streamlinkPath + "/" + getBinaryName();
+                const QString path = getSettings()->streamlinkPath;
-            }
+                return path.trimmed() + "/" + getBinaryName();
-            else
-            {
-                return QString{getBinaryName()};
             }
+
+            return {getBinaryName()};
         }();
 
         if (Version::instance().isFlatpak())