chatterino2
Code Issues

No longer add username to the completion model in privateMessageReceived

Browse Source 
The username is added to the completion model with the
"addRecentChatter" method instead

Moved "NameOptions" stuff from base class Channel to TwitchChannel where
it belongs

Remove unused Channel::getUsernamesForCompletions method
This commit is contained in:
Rasmus Karlsson
2018-03-30 12:16:12 +02:00
committed by fourtf
parent d9d699b6f1
commit c7a86f8abe
5 changed files with 25 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/channel.cpp
+2 -19
View File
@@ -79,25 +79,7 @@ void Channel::replaceMessage(messages::MessagePtr message, messages::MessagePtr
void Channel::addRecentChatter(const std::shared_ptr<messages::Message> &message)
{
assert(!message->loginName.isEmpty());
std::lock_guard<std::mutex> lock(this->recentChattersMutex);
this->recentChatters[message->loginName] = {message->displayName, message->localizedName};
}
std::vector<Channel::NameOptions> Channel::getUsernamesForCompletions()
{
std::vector<NameOptions> names;
this->recentChattersMutex.lock();
for (const auto &p : this->recentChatters) {
names.push_back(p.second);
}
// usernames.insert(this->recentChatters.begin(), this->recentChatters.end());
this->recentChattersMutex.unlock();
return names;
// Do nothing by default
}
bool Channel::canSendMessage() const
@@ -118,4 +100,5 @@ std::shared_ptr<Channel> Channel::getEmpty()
void Channel::onConnected()
{
}
} // namespace chatterino