From c8e03b4ad7fbdc3a2c3ff8a2415bf1e13f61078d Mon Sep 17 00:00:00 2001 From: kornes <28986062+kornes@users.noreply.github.com> Date: Wed, 8 Nov 2023 21:19:18 +0000 Subject: [PATCH] Dont invalidate paint buffer when selecting (#4911) --- CHANGELOG.md | 2 +- src/messages/layouts/MessageLayout.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 36d82497..130cfb8c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -52,7 +52,7 @@ - Dev: Add a compile-time flag `USE_SYSTEM_MINIAUDIO` which can be turned on to use the system miniaudio. (#4867) - Dev: Update vcpkg to use Qt6. (#4872) - Dev: Replace `boost::optional` with `std::optional`. (#4877) -- Dev: Improve performance by reducing repaints caused by selections. (#4889) +- Dev: Improve performance of selecting text. (#4889, #4911) - Dev: Removed direct dependency on Qt 5 compatibility module. (#4906) - Dev: Refactor `DebugCount` and add copy button to debug popup. (#4921) - Dev: Changed lifetime of context menus. (#4924) diff --git a/src/messages/layouts/MessageLayout.cpp b/src/messages/layouts/MessageLayout.cpp index a2d961bd..d80eba7d 100644 --- a/src/messages/layouts/MessageLayout.cpp +++ b/src/messages/layouts/MessageLayout.cpp @@ -200,7 +200,7 @@ void MessageLayout::paint(const MessagePaintContext &ctx) { QPixmap *pixmap = this->ensureBuffer(ctx.painter, ctx.canvasWidth); - if (!this->bufferValid_ || !ctx.selection.isEmpty()) + if (!this->bufferValid_) { this->updateBuffer(pixmap, ctx); }