chatterino2
Code Issues

chore: unsingletonize UserDataController (#5459)

Browse Source 
The `user-data.json` file will save immediately on change, and on exit
(on dtor) if necessary. So we don't need to manually call save
This commit is contained in:
pajlada
2024-06-16 13:59:12 +02:00
committed by GitHub
parent a714bf066f
commit c9a0691f53
5 changed files with 6 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Application.cpp
+3 -2
View File
@@ -135,7 +135,7 @@ Application::Application(Settings &_settings, const Paths &paths,
, twitch(new TwitchIrcServer)
, ffzBadges(&this->emplace<FfzBadges>())
, seventvBadges(&this->emplace<SeventvBadges>())
, userData(&this->emplace(new UserDataController(paths)))
, userData(new UserDataController(paths))
, sound(&this->emplace<ISoundController>(makeSoundController(_settings)))
, twitchLiveController(&this->emplace<TwitchLiveController>())
, twitchPubSub(new PubSub(TWITCH_PUBSUB_URL))
@@ -173,6 +173,7 @@ void Application::fakeDtor()
this->seventvEmotes.reset();
// this->twitch.reset();
this->fonts.reset();
this->userData.reset();
}
void Application::initialize(Settings &settings, const Paths &paths)
@@ -427,7 +428,7 @@ IUserDataController *Application::getUserData()
{
assertInGuiThread();
return this->userData;
return this->userData.get();
}
ISoundController *Application::getSound()