From cada32edfdccea31727eed5b8e25dcb11ea7381d Mon Sep 17 00:00:00 2001
From: Rasmus Karlsson <rasmus.karlsson@pajlada.com>
Date: Sat, 7 Jul 2018 10:38:56 +0000
Subject: [PATCH] Treat missing returns as errors

---
 chatterino.pro                         | 2 ++
 src/providers/twitch/TwitchChannel.cpp | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/chatterino.pro b/chatterino.pro
index a7be1fb4..f149affc 100644
--- a/chatterino.pro
+++ b/chatterino.pro
@@ -446,6 +446,8 @@ win32-msvc* {
     # Disabling strict-aliasing warnings for now, although we probably want to re-enable this in the future
     QMAKE_CXXFLAGS_WARN_ON += -Wno-strict-aliasing
 
+    QMAKE_CXXFLAGS_WARN_ON += -Werror=return-type
+
     equals(QMAKE_CXX, "clang++") {
         QMAKE_CXXFLAGS_WARN_ON += -Wno-unused-local-typedef
     } else {
diff --git a/src/providers/twitch/TwitchChannel.cpp b/src/providers/twitch/TwitchChannel.cpp
index d95834c1..688ac906 100644
--- a/src/providers/twitch/TwitchChannel.cpp
+++ b/src/providers/twitch/TwitchChannel.cpp
@@ -153,7 +153,7 @@ void TwitchChannel::sendMessage(const QString &message)
     // Do last message processing
     QString parsedMessage = app->emotes->emojis.replaceShortCodes(message);
 
-    parsedMessage = parsedMessage.trimmed();
+    parsedMessage.trim();
 
     if (parsedMessage.isEmpty()) {
         return;