chatterino2
Code Issues

chore: remove dead code and get rid of MSVC warnings (#6024)

Browse Source
This commit is contained in:
nerix
2025-03-03 13:30:11 +01:00
committed by GitHub
parent d7166fae9f
commit cd8247f921
7 changed files with 9 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/common/Channel.cpp
+2 -7
View File
@@ -283,9 +283,9 @@ void Channel::replaceMessage(size_t hint, const MessagePtr &message,
}
}
void Channel::disableMessage(QString messageID)
void Channel::disableMessage(const QString &messageID)
{
auto msg = this->findMessage(messageID);
auto msg = this->findMessageByID(messageID);
if (msg != nullptr)
{
msg->flags.set(MessageFlag::Disabled);
@@ -298,11 +298,6 @@ void Channel::clearMessages()
this->messagesCleared.invoke();
}
MessagePtr Channel::findMessage(QString messageID)
{
return this->findMessageByID(messageID);
}
MessagePtr Channel::findMessageByID(QStringView messageID)
{
MessagePtr res;
src/common/Channel.hpp
+1 -3
View File
@@ -99,13 +99,11 @@ public:
void replaceMessage(size_t index, const MessagePtr &replacement);
void replaceMessage(size_t hint, const MessagePtr &message,
const MessagePtr &replacement);
void disableMessage(QString messageID);
void disableMessage(const QString &messageID);
/// Removes all messages from this channel and invokes #messagesCleared
void clearMessages();
[[deprecated("Use findMessageByID instead")]] MessagePtr findMessage(
QString messageID);
MessagePtr findMessageByID(QStringView messageID) final;
bool hasMessages() const;