chatterino2
Code Issues

Refactor/Cleanup NetworkRequest and Related Code (#4633)

Browse Source 
Cleanup unused code (Twitch v5)
Add json methods that simplify sending JSON. This also sets the Accepts header, since here, when JSON is sent, only JSON is accepted as a response (this is only done in Helix).
Clarify helix request creations
Cleaned some clang-tidy suggestions in Network{Request,Private}
This commit is contained in:
nerix
2023-05-16 17:28:20 +02:00
committed by GitHub
parent 4fa2cc26c9
commit ce47d27d41
6 changed files with 184 additions and 170 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/providers/twitch/api/Helix.hpp
+7 -1
View File
@@ -1361,7 +1361,13 @@ protected:
FailureCallback<HelixGetModeratorsError, QString> failureCallback);
private:
NetworkRequest makeRequest(QString url, QUrlQuery urlQuery);
NetworkRequest makeRequest(const QString &url, const QUrlQuery &urlQuery,
NetworkRequestType type);
NetworkRequest makeGet(const QString &url, const QUrlQuery &urlQuery);
NetworkRequest makeDelete(const QString &url, const QUrlQuery &urlQuery);
NetworkRequest makePost(const QString &url, const QUrlQuery &urlQuery);
NetworkRequest makePut(const QString &url, const QUrlQuery &urlQuery);
NetworkRequest makePatch(const QString &url, const QUrlQuery &urlQuery);
QString clientId;
QString oauthToken;