fix: deadlock and use-after-free in tests (#4981)

* fix: use-after-free in settings

* refactor: put seventv api into a singleton

* chore: add changelog entry

* Add warning for when the 7TV load fails
This commit is contained in:
nerix
2023-11-26 16:54:19 +01:00
committed by GitHub
parent 854032fce9
commit e8673fc52a
12 changed files with 57 additions and 27 deletions
+5 -1
View File
@@ -137,6 +137,7 @@ bool Settings::toggleMutedChannel(const QString &channelName)
Settings *Settings::instance_ = nullptr;
Settings::Settings(const QString &settingsDirectory)
: prevInstance_(Settings::instance_)
{
QString settingsPath = settingsDirectory + "/settings.json";
@@ -188,7 +189,10 @@ Settings::Settings(const QString &settingsDirectory)
false);
}
Settings::~Settings() = default;
Settings::~Settings()
{
Settings::instance_ = this->prevInstance_;
}
void Settings::saveSnapshot()
{