chatterino2
Code Issues

fix: benchmarks segfaulting (#5559)

Browse Source
This commit is contained in:
pajlada
2024-08-24 15:28:45 +02:00
committed by GitHub
parent 9f588b7406
commit f4d6845587
2 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CHANGELOG.md
+1
View File
@@ -74,6 +74,7 @@
- Dev: Refactored a few `#define`s into `const(expr)` and cleaned includes. (#5527) - Dev: Refactored a few `#define`s into `const(expr)` and cleaned includes. (#5527)
- Dev: Added `FlagsEnum::isEmpty`. (#5550) - Dev: Added `FlagsEnum::isEmpty`. (#5550)
- Dev: Prepared for Qt 6.8 by addressing some deprecations. (#5529) - Dev: Prepared for Qt 6.8 by addressing some deprecations. (#5529)
- Dev: Fixed benchmarks segfaulting on run. (#5559)
- Dev: Refactored `MessageBuilder` to be a single class. (#5548) - Dev: Refactored `MessageBuilder` to be a single class. (#5548)
- Dev: Recent changes are now shown in the nightly release description. (#5553, #5554) - Dev: Recent changes are now shown in the nightly release description. (#5553, #5554)
benchmarks/src/Highlights.cpp
+7
View File
@@ -6,6 +6,7 @@
#include "messages/Message.hpp" #include "messages/Message.hpp"
#include "messages/MessageBuilder.hpp" #include "messages/MessageBuilder.hpp"
#include "mocks/BaseApplication.hpp" #include "mocks/BaseApplication.hpp"
#include "mocks/UserData.hpp"
#include "util/Helpers.hpp" #include "util/Helpers.hpp"
#include <benchmark/benchmark.h> #include <benchmark/benchmark.h>
@@ -64,8 +65,14 @@ public:
return &this->highlights; return &this->highlights;
} }
IUserDataController *getUserData() override
{
return &this->userData;
}
AccountController accounts; AccountController accounts;
HighlightController highlights; HighlightController highlights;
mock::UserDataController userData;
}; };
static void BM_HighlightTest(benchmark::State &state) static void BM_HighlightTest(benchmark::State &state)