From d2ef352ce9a72f123e12cf0894964a31abaa9eef Mon Sep 17 00:00:00 2001
From: ruinivist <ruinivist@proton.me>
Date: Sun, 11 Jan 2026 23:24:27 +0000
Subject: [PATCH] fix bug: unsubscribe while notif

---
 subscriber-notifs/include/core/subscribable.hpp | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/subscriber-notifs/include/core/subscribable.hpp b/subscriber-notifs/include/core/subscribable.hpp
index dc47bc5..e6c8159 100644
--- a/subscriber-notifs/include/core/subscribable.hpp
+++ b/subscriber-notifs/include/core/subscribable.hpp
@@ -39,7 +39,10 @@ class Subscribable {
             return;
         }
 
-        for (auto& subscriber : entry->second) {
+        // edge case: if a subscriber unsubscribes itself during notification
+        // this modifies the vector and makes my iterators invalid
+        auto subscribersCopy = entry->second;
+        for (auto& subscriber : subscribersCopy) {
             subscriber->onNotification(eventId, eventInfo);
         }
     }