mend
Code Issues

improve layout code

Browse Source
This commit is contained in:
ruinivist
2026-01-04 02:33:55 +00:00
parent 2caa47b8d0
commit 92efbf61aa
1 changed files with 4 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
layout.go
+4 -13
View File
@@ -1,6 +1,6 @@
package main package main
// Layout constants to avoid magic numbers // layout constants
const ( const (
minFsTreeWidth = 5 minFsTreeWidth = 5
minNoteViewWidth = 10 minNoteViewWidth = 10
@@ -10,20 +10,16 @@ const (
// calculateLayout computes the widths for the file tree and note view // calculateLayout computes the widths for the file tree and note view
// based on the terminal dimensions and the desired tree width. // based on the terminal dimensions and the desired tree width.
// It returns the constrained tree width and the resulting note view width.
func calculateLayout(totalWidth, requestedTreeWidth int) (treeWidth, noteWidth int) { func calculateLayout(totalWidth, requestedTreeWidth int) (treeWidth, noteWidth int) {
treeWidth = requestedTreeWidth treeWidth = requestedTreeWidth
// Default initial width if not set
if treeWidth == 0 { if treeWidth == 0 {
treeWidth = totalWidth / 4 treeWidth = totalWidth / 4
} }
// Calculate maximum allowed width for the tree
// Total width - divider - minimum note view width
maxTreeWidth := totalWidth - dividerWidth - minNoteViewWidth maxTreeWidth := totalWidth - dividerWidth - minNoteViewWidth
// Apply constraints // constraints
if treeWidth > maxTreeWidth { if treeWidth > maxTreeWidth {
treeWidth = maxTreeWidth treeWidth = maxTreeWidth
} }
@@ -31,12 +27,7 @@ func calculateLayout(totalWidth, requestedTreeWidth int) (treeWidth, noteWidth i
treeWidth = minFsTreeWidth treeWidth = minFsTreeWidth
} }
noteWidth = totalWidth - treeWidth - dividerWidth noteWidth = max(0, totalWidth-treeWidth-dividerWidth)
// Safety check to ensure noteWidth is never negative
if noteWidth < 0 {
noteWidth = 0
}
return treeWidth, noteWidth return treeWidth, noteWidth
} }