feat: add support for path arg in miro test

2026-03-20 21:43:50 +00:00
parent b1061ee1af
commit 705933726e
4 changed files with 221 additions and 48 deletions
@@ -239,6 +239,99 @@ func TestRunTest(t *testing.T) {
 	})
 }

+func TestRunTestScopedDirectory(t *testing.T) {
+	addFakeRecordDependencies(t, "script", "bwrap", "bash")
+	t.Setenv("FAKE_SCRIPT_ECHO_STDIN", "1")
+
+	root := t.TempDir()
+	writeScenarioFixtures(t, filepath.Join(root, "e2e", "a"), "echo one\n", "echo one\n")
+	writeScenarioFixtures(t, filepath.Join(root, "e2e", "nested", "b"), "echo two\n", "echo two\n")
+	writeScenarioFixtures(t, filepath.Join(root, "e2e", "nested", "c"), "echo three\n", "echo three\n")
+
+	withWorkingDir(t, root, func() {
+		initStdout, initStderr := captureOutput(t, func() {
+			if got := Run([]string{"init"}); got != 0 {
+				t.Fatalf("Run() code = %d, want %d", got, 0)
+			}
+		})
+		if initStdout != prefixed("Done initialising...\n") {
+			t.Fatalf("stdout = %q, want %q", initStdout, prefixed("Done initialising...\n"))
+		}
+		if initStderr != "" {
+			t.Fatalf("stderr = %q, want empty", initStderr)
+		}
+
+		stdout, stderr := captureOutput(t, func() {
+			if got := Run([]string{"test", "nested"}); got != 0 {
+				t.Fatalf("Run() code = %d, want %d", got, 0)
+			}
+		})
+
+		for _, want := range []string{
+			"RUN nested/b",
+			"PASS nested/b",
+			"RUN nested/c",
+			"PASS nested/c",
+			"Summary: total=2 passed=2 failed=0",
+		} {
+			if !strings.Contains(stdout, want) {
+				t.Fatalf("stdout = %q, want substring %q", stdout, want)
+			}
+		}
+		if strings.Contains(stdout, "RUN a") {
+			t.Fatalf("stdout = %q, want scoped run to exclude scenario outside nested", stdout)
+		}
+		if stderr != "" {
+			t.Fatalf("stderr = %q, want empty", stderr)
+		}
+	})
+}
+
+func TestRunTestScopedLeafDirectory(t *testing.T) {
+	addFakeRecordDependencies(t, "script", "bwrap", "bash")
+	t.Setenv("FAKE_SCRIPT_ECHO_STDIN", "1")
+
+	root := t.TempDir()
+	writeScenarioFixtures(t, filepath.Join(root, "e2e", "a"), "echo one\n", "echo one\n")
+	writeScenarioFixtures(t, filepath.Join(root, "e2e", "nested", "b"), "echo two\n", "echo two\n")
+
+	withWorkingDir(t, root, func() {
+		initStdout, initStderr := captureOutput(t, func() {
+			if got := Run([]string{"init"}); got != 0 {
+				t.Fatalf("Run() code = %d, want %d", got, 0)
+			}
+		})
+		if initStdout != prefixed("Done initialising...\n") {
+			t.Fatalf("stdout = %q, want %q", initStdout, prefixed("Done initialising...\n"))
+		}
+		if initStderr != "" {
+			t.Fatalf("stderr = %q, want empty", initStderr)
+		}
+
+		stdout, stderr := captureOutput(t, func() {
+			if got := Run([]string{"test", filepath.Join("nested", "b")}); got != 0 {
+				t.Fatalf("Run() code = %d, want %d", got, 0)
+			}
+		})
+
+		for _, want := range []string{
+			"RUN nested/b",
+			"PASS nested/b",
+			"Summary: total=1 passed=1 failed=0",
+		} {
+			if !strings.Contains(stdout, want) {
+				t.Fatalf("stdout = %q, want substring %q", stdout, want)
+			}
+		}
+		if strings.Contains(stdout, "RUN a") {
+			t.Fatalf("stdout = %q, want scoped run to exclude scenario outside nested/b", stdout)
+		}
+		if stderr != "" {
+			t.Fatalf("stderr = %q, want empty", stderr)
+		}
+	})
+}
+
 func TestRunTestReturnsOneWhenScenarioMismatches(t *testing.T) {
 	addFakeRecordDependencies(t, "script", "bwrap", "bash")
 	t.Setenv("FAKE_SCRIPT_ECHO_STDIN", "1")
@@ -401,6 +494,26 @@ func TestRunRecordMissingPath(t *testing.T) {
 	}
 }

+func TestRunTestExtraArgs(t *testing.T) {
+	addFakeRecordDependencies(t, "script", "bwrap", "bash")
+
+	stdout, stderr := captureOutput(t, func() {
+		if got := Run([]string{"test", "a", "b"}); got != 1 {
+			t.Fatalf("Run() code = %d, want %d", got, 1)
+		}
+	})
+
+	if stdout != "" {
+		t.Fatalf("stdout = %q, want empty", stdout)
+	}
+	if !strings.Contains(stderr, "accepts at most 1 arg(s), received 2") {
+		t.Fatalf("stderr = %q, want extra-arg error", stderr)
+	}
+	if !strings.Contains(stderr, "Usage:") || !strings.Contains(stderr, "miro test [path]") {
+		t.Fatalf("stderr = %q, want test usage", stderr)
+	}
+}
+
 func TestRunInitExtraArgs(t *testing.T) {
 	addFakeRecordDependencies(t, "script", "bwrap", "bash")

@@ -1,6 +1,8 @@
 package cmd

 import (
+	"path/filepath"
+
 	"miro/internal/miro"

 	"github.com/spf13/cobra"
@@ -8,10 +10,15 @@ import (

 func newTestCommand() *cobra.Command {
 	return &cobra.Command{
-		Use:  "test",
-		Args: cobra.NoArgs,
-		RunE: func(_ *cobra.Command, _ []string) error {
-			return miro.RunTests()
+		Use:  "test [path]",
+		Args: cobra.MaximumNArgs(1),
+		RunE: func(_ *cobra.Command, args []string) error {
+			path := ""
+			if len(args) == 1 {
+				path = filepath.Clean(args[0])
+			}
+
+			return miro.RunTests(path)
 		},
 	}
 }