refactor: path resolution to separate file

This commit is contained in:
2026-03-20 21:23:37 +00:00
parent e5b767e35f
commit b1061ee1af
5 changed files with 155 additions and 154 deletions
-32
View File
@@ -3,8 +3,6 @@ package miro
import (
"fmt"
"os"
"path/filepath"
"strings"
)
// Record creates the requested scenario path under the resolved test directory
@@ -49,33 +47,3 @@ func Record(path string) (string, error) {
return target, nil
}
func resolveRecordTarget(testDir, path string) (string, error) {
absTestDir, err := filepath.Abs(testDir)
if err != nil {
return "", fmt.Errorf("failed to resolve test directory path: %v", err)
}
absPath, err := filepath.Abs(path)
if err != nil {
return "", fmt.Errorf("failed to resolve record path: %v", err)
}
// path rel to testDir
relToTestDir, err := filepath.Rel(absTestDir, absPath)
if err == nil && isWithinBase(relToTestDir) {
return filepath.Join(absTestDir, relToTestDir), nil
}
// not rel to test dir and absolute path given
if filepath.IsAbs(path) {
return "", fmt.Errorf("record path %q must be inside test directory %q", path, absTestDir)
}
return filepath.Join(absTestDir, path), nil
}
// is the rel path going "outside"
func isWithinBase(rel string) bool {
return rel == "." || (rel != ".." && !strings.HasPrefix(rel, ".."+string(os.PathSeparator)))
}