fix: add raced handling for mire record to handle delays for breaking stdin

This commit is contained in:
2026-03-24 23:05:40 +00:00
parent 2171e2d907
commit be4c143b9d
10 changed files with 419 additions and 18 deletions
+2 -2
View File
@@ -24,8 +24,8 @@ func newRecordCommand() *cobra.Command {
if errors.Is(err, mire.ErrRecordingDiscarded) {
return nil
}
cmd.PrintErrln(err)
return nil
cmd.SilenceUsage = true
return err
}
output.Println(createdPath)
+34
View File
@@ -172,6 +172,40 @@ func TestRunRecordSaveFlagSkipsPrompt(t *testing.T) {
})
}
func TestRunRecordReturnsNonZeroWhenVerificationFails(t *testing.T) {
testutil.AddFakeRecordDependencies(t, "bwrap", "bash")
root := t.TempDir()
testDir := filepath.Join(root, "e2e")
testutil.WriteValidConfig(t, filepath.Join(root, "mire.toml"), "e2e")
testutil.WriteFile(t, filepath.Join(testDir, "shell.sh"), "#!/bin/sh\nexit 0\n")
if err := os.Chmod(filepath.Join(testDir, "shell.sh"), 0o755); err != nil {
t.Fatalf("Chmod(shell.sh) error = %v", err)
}
testutil.WithWorkingDir(t, root, func() struct{} {
testutil.WithStdin(t, "", func() {
stdout, stderr := testutil.CaptureOutput(t, func() {
if got := Run([]string{"record", "--save", "suite/spec"}); got != 1 {
t.Fatalf("Run() code = %d, want %d", got, 1)
}
})
if stdout != "" {
t.Fatalf("stdout = %q, want empty", stdout)
}
if !strings.Contains(stderr, "internal mire failure - failed to replicate within time") {
t.Fatalf("stderr = %q, want propagated record failure", stderr)
}
if strings.Contains(stderr, "Usage:") {
t.Fatalf("stderr = %q, want usage suppressed", stderr)
}
})
return struct{}{}
})
}
func TestRunRewrite(t *testing.T) {
testutil.AddFakeRecordDependencies(t, "bwrap", "bash")