fix: supress within record pty exit codes

internal/mire/record_session.go

@@ -41,9 +41,9 @@ func recordScenario(target, shellPath string, rio recordIO, sandboxConfig map[st
 
 	output.Fprintln(rio.err, "Run commands in the recorder shell, then type exit to finish.")
 
-	if err := runRecordSession(target, rawIn, rawOut, shellPath, sandbox, rio, sandboxConfig, setupScripts); err != nil {
-		return err
-	}
+	// this error is intentionally discarded to avoid non zero exit status inside record
+	// as an error
+	runRecordSession(target, rawIn, rawOut, shellPath, sandbox, rio, sandboxConfig, setupScripts)
 
 	save, err := confirmRecordSave(rio)
 	if err != nil {

internal/mire/record_shell.sh

@@ -1,7 +1,6 @@
 #!/bin/sh
 set -eu
 
-# hoisted vars to fail fast if any missing
 host_home=${MIRE_HOST_HOME:?}
 host_tmp=${MIRE_HOST_TMP:?}
 path_env=${MIRE_PATH_ENV:?}