playwriter
Code Issues

Allow attaching to our own extension pages while blocking other extensions

Browse Source
This commit is contained in:
Tommy D. Rossi
2026-01-14 12:07:28 +01:00
parent cfe3059fee
commit 1fd0242277
1 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
extension/src/background.ts
+14 -1
View File
@@ -890,11 +890,24 @@ async function resetDebugger(): Promise<void> {
} }
} }
// Our extension IDs - allow attaching to our own extension pages for debugging
const OUR_EXTENSION_IDS = [
'jfeammnjpkecdekppnclgkkffahnhfhe', // Production extension (Chrome Web Store)
'elnnakgjclnapgflmidlpobefkdmapdm', // Dev extension (loaded unpacked)
]
// undefined URL is for about:blank pages (not restricted) and chrome:// URLs (restricted). // undefined URL is for about:blank pages (not restricted) and chrome:// URLs (restricted).
// We can't distinguish them without the `tabs` permission, so we just let attachment fail. // We can't distinguish them without the `tabs` permission, so we just let attachment fail.
function isRestrictedUrl(url: string | undefined): boolean { function isRestrictedUrl(url: string | undefined): boolean {
if (!url) return false if (!url) return false
const restrictedPrefixes = ['chrome://', 'chrome-extension://', 'devtools://', 'edge://', 'https://chrome.google.com/', 'https://chromewebstore.google.com/']
// Allow our own extension pages, block all other extensions
if (url.startsWith('chrome-extension://')) {
const extensionId = url.replace('chrome-extension://', '').split('/')[0]
return !OUR_EXTENSION_IDS.includes(extensionId)
}
const restrictedPrefixes = ['chrome://', 'devtools://', 'edge://', 'https://chrome.google.com/', 'https://chromewebstore.google.com/']
return restrictedPrefixes.some((prefix) => url.startsWith(prefix)) return restrictedPrefixes.some((prefix) => url.startsWith(prefix))
} }