playwriter
Code Issues

more logs when url is empty

Browse Source
This commit is contained in:
Tommy D. Rossi
2026-01-02 14:40:03 +01:00
parent 7630ab7538
commit 5cf7d2756e
1 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
playwriter/src/cdp-relay.ts
+13 -1
View File
@@ -220,7 +220,7 @@ export async function startPlayWriterCDPRelayServer({ port = 19988, host = '127.
targetId: result.targetInfo.targetId, targetId: result.targetInfo.targetId,
targetInfo: result.targetInfo targetInfo: result.targetInfo
}) })
logger?.log(chalk.blue(`Auto-created tab, now have ${connectedTargets.size} targets`)) logger?.log(chalk.blue(`Auto-created tab, now have ${connectedTargets.size} targets, url: ${result.targetInfo.url}`))
} }
} catch (e) { } catch (e) {
logger?.error('Failed to auto-create initial tab:', e) logger?.error('Failed to auto-create initial tab:', e)
@@ -460,6 +460,9 @@ export async function startPlayWriterCDPRelayServer({ port = 19988, host = '127.
waitingForDebugger: false waitingForDebugger: false
} }
} satisfies CDPEventFor<'Target.attachedToTarget'> } satisfies CDPEventFor<'Target.attachedToTarget'>
if (!target.targetInfo.url) {
logger?.error(chalk.red('[Server] WARNING: Target.attachedToTarget sent with empty URL!'), JSON.stringify(attachedPayload))
}
logger?.log(chalk.magenta('[Server] Target.attachedToTarget full payload:'), JSON.stringify(attachedPayload)) logger?.log(chalk.magenta('[Server] Target.attachedToTarget full payload:'), JSON.stringify(attachedPayload))
sendToPlaywright({ sendToPlaywright({
message: attachedPayload, message: attachedPayload,
@@ -480,6 +483,9 @@ export async function startPlayWriterCDPRelayServer({ port = 19988, host = '127.
} }
} }
} satisfies CDPEventFor<'Target.targetCreated'> } satisfies CDPEventFor<'Target.targetCreated'>
if (!target.targetInfo.url) {
logger?.error(chalk.red('[Server] WARNING: Target.targetCreated sent with empty URL!'), JSON.stringify(targetCreatedPayload))
}
logger?.log(chalk.magenta('[Server] Target.targetCreated full payload:'), JSON.stringify(targetCreatedPayload)) logger?.log(chalk.magenta('[Server] Target.targetCreated full payload:'), JSON.stringify(targetCreatedPayload))
sendToPlaywright({ sendToPlaywright({
message: targetCreatedPayload, message: targetCreatedPayload,
@@ -504,6 +510,9 @@ export async function startPlayWriterCDPRelayServer({ port = 19988, host = '127.
waitingForDebugger: false waitingForDebugger: false
} }
} satisfies CDPEventFor<'Target.attachedToTarget'> } satisfies CDPEventFor<'Target.attachedToTarget'>
if (!target.targetInfo.url) {
logger?.error(chalk.red('[Server] WARNING: Target.attachedToTarget (from attachToTarget) sent with empty URL!'), JSON.stringify(attachedPayload))
}
logger?.log(chalk.magenta('[Server] Target.attachedToTarget (from attachToTarget) payload:'), JSON.stringify(attachedPayload)) logger?.log(chalk.magenta('[Server] Target.attachedToTarget (from attachToTarget) payload:'), JSON.stringify(attachedPayload))
sendToPlaywright({ sendToPlaywright({
message: attachedPayload, message: attachedPayload,
@@ -617,6 +626,9 @@ export async function startPlayWriterCDPRelayServer({ port = 19988, host = '127.
if (method === 'Target.attachedToTarget') { if (method === 'Target.attachedToTarget') {
const targetParams = params as Protocol.Target.AttachedToTargetEvent const targetParams = params as Protocol.Target.AttachedToTargetEvent
if (!targetParams.targetInfo.url) {
logger?.error(chalk.red('[Extension] WARNING: Target.attachedToTarget received with empty URL!'), JSON.stringify({ method, params: targetParams, sessionId }))
}
logger?.log(chalk.yellow('[Extension] Target.attachedToTarget full payload:'), JSON.stringify({ method, params: targetParams, sessionId })) logger?.log(chalk.yellow('[Extension] Target.attachedToTarget full payload:'), JSON.stringify({ method, params: targetParams, sessionId }))
// Check if we already sent this target to clients (e.g., from Target.setAutoAttach response) // Check if we already sent this target to clients (e.g., from Target.setAutoAttach response)