playwriter
Code Issues

add a missing disconnected state

Browse Source
This commit is contained in:
Tommy D. Rossi
2025-11-25 10:36:40 +01:00
parent 0df52a08c0
commit 5d4abb3cde
1 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
extension/src/background.ts
+6 -7
View File
@@ -257,7 +257,7 @@ function onDebuggerDetach(source: chrome.debugger.Debuggee, reason: `${chrome.de
}) })
if (reason === chrome.debugger.DetachReason.CANCELED_BY_USER) { if (reason === chrome.debugger.DetachReason.CANCELED_BY_USER) {
store.setState({ connectionState: 'disconnected' }) store.setState({ connectionState: 'disconnected', errorText: undefined })
} }
} }
@@ -283,7 +283,7 @@ async function attachTab(tabId: number): Promise<Protocol.Target.TargetInfo> {
targetId: targetInfo.targetId, targetId: targetInfo.targetId,
state: 'connected', state: 'connected',
}) })
return { tabs: newTabs, connectionState: 'connected' } return { tabs: newTabs, connectionState: 'connected', errorText: undefined }
}) })
sendMessage({ sendMessage({
@@ -351,7 +351,7 @@ function closeConnection(reason: string): void {
}) })
} }
store.setState({ tabs: new Map() }) store.setState({ tabs: new Map(), connectionState: 'disconnected', errorText: undefined })
childSessions.clear() childSessions.clear()
if (ws) { if (ws) {
@@ -386,7 +386,7 @@ function handleConnectionClose(reason: string, code: number): void {
return return
} }
store.setState({ connectionState: 'disconnected' }) store.setState({ connectionState: 'disconnected', errorText: undefined })
if (tabs.size > 0) { if (tabs.size > 0) {
logger.debug('Tabs still connected, triggering reconnection') logger.debug('Tabs still connected, triggering reconnection')
@@ -527,7 +527,6 @@ async function disconnectTab(tabId: number): Promise<void> {
if (updatedTabs.size === 0 && ws) { if (updatedTabs.size === 0 && ws) {
logger.debug('No tabs remaining, closing connection') logger.debug('No tabs remaining, closing connection')
closeConnection('All tabs disconnected') closeConnection('All tabs disconnected')
store.setState({ connectionState: 'disconnected' })
} }
} }
@@ -562,9 +561,9 @@ async function reconnect(): Promise<void> {
const { tabs: finalTabs } = store.getState() const { tabs: finalTabs } = store.getState()
if (finalTabs.size > 0) { if (finalTabs.size > 0) {
store.setState({ connectionState: 'connected' }) store.setState({ connectionState: 'connected', errorText: undefined })
} else { } else {
store.setState({ connectionState: 'disconnected' }) store.setState({ connectionState: 'disconnected', errorText: undefined })
} }
} catch (error: any) { } catch (error: any) {
logger.debug('Reconnection failed:', error) logger.debug('Reconnection failed:', error)