diff --git a/playwriter/CHANGELOG.md b/playwriter/CHANGELOG.md index 1c91a0a..26d0433 100644 --- a/playwriter/CHANGELOG.md +++ b/playwriter/CHANGELOG.md @@ -1,5 +1,17 @@ # Changelog +## 0.0.68 + +### Tests + +- **Use a more realistic complex page in aria label screenshot test**: Replaced `example.com` with `old.reddit.com` in the optimized label rendering integration test to keep stronger real-world DOM coverage while preserving faster runtime. + +## 0.0.67 + +### Tests + +- **Speed up aria label screenshot integration test**: Reduced the `should show aria ref labels on real pages and save screenshots` runtime by loading fewer external pages, removing `networkidle` waits, and parallelizing initial page loading. + ## 0.0.66 ### Internal diff --git a/playwriter/package.json b/playwriter/package.json index 6f1d5cf..3d7b7db 100644 --- a/playwriter/package.json +++ b/playwriter/package.json @@ -1,7 +1,7 @@ { "name": "playwriter", "description": "", - "version": "0.0.66", + "version": "0.0.68", "type": "module", "main": "dist/index.js", "types": "dist/index.d.ts", diff --git a/playwriter/src/snapshot-tools.test.ts b/playwriter/src/snapshot-tools.test.ts index 5df166c..9a1d68c 100644 --- a/playwriter/src/snapshot-tools.test.ts +++ b/playwriter/src/snapshot-tools.test.ts @@ -747,9 +747,8 @@ describe('Snapshot & Screenshot Tests', () => { } const testPages = [ + { name: 'old-reddit', url: 'https://old.reddit.com/' }, { name: 'hacker-news', url: 'https://news.ycombinator.com/' }, - { name: 'google', url: 'https://www.google.com/' }, - { name: 'github', url: 'https://github.com/' }, ] const loadPageWithRetries = async ({ name, url }: { name: string; url: string }) => { @@ -761,8 +760,7 @@ describe('Snapshot & Screenshot Tests', () => { for (let attempt = 1; attempt <= attempts; attempt += 1) { try { console.log(`[labels] opening ${name}: ${url} (attempt ${attempt}/${attempts})`) - await page.goto(url, { waitUntil: 'domcontentloaded' }) - await page.waitForLoadState('networkidle', { timeout: 15000 }) + await page.goto(url, { waitUntil: 'load' }) console.log(`[labels] loaded ${name}: ${page.url()}`) return { name, url, page } } catch (error) { @@ -774,10 +772,9 @@ describe('Snapshot & Screenshot Tests', () => { throw new Error(`Failed to load ${name} after ${attempts} attempts`, { cause: lastError instanceof Error ? lastError : undefined }) } - const pages: Array<{ name: string; url: string; page: Page }> = [] - for (const testPage of testPages) { - pages.push(await loadPageWithRetries(testPage)) - } + const pages = await Promise.all(testPages.map((testPage) => { + return loadPageWithRetries(testPage) + })) for (const { page } of pages) { await page.bringToFront() @@ -824,9 +821,7 @@ describe('Snapshot & Screenshot Tests', () => { 60000 ) console.log(`${name}: ${labelCount} labels shown`) - if (name !== 'google') { - expect(labelCount).toBeGreaterThan(0) - } + expect(labelCount).toBeGreaterThan(0) console.log(`[labels] screenshot ${name}`) const screenshot = await withTimeout(