fix(cdp): isolate extension builds and keep oopif auto-attach

This commit is contained in:
Tommy D. Rossi
2026-01-27 16:05:15 +01:00
parent a8412343e1
commit 67d017237e
8 changed files with 224 additions and 17 deletions
+36
View File
@@ -23,6 +23,9 @@ function sleep(ms: number): Promise<void> {
let childSessions: Map<string, { tabId: number; targetId?: string }> = new Map()
let nextSessionId = 1
let tabGroupQueue: Promise<void> = Promise.resolve()
// Cache Target.setAutoAttach params so existing and future tabs enable OOPIF target events.
// This ensures Playwright can build the iframe frame tree when connecting over CDP.
let autoAttachParams: Protocol.Target.SetAutoAttachRequest | null = null
class ConnectionManager {
ws: WebSocket | null = null
@@ -673,6 +676,30 @@ async function handleCommand(msg: ExtensionCommandMessage): Promise<any> {
const debuggee = targetTabId ? { tabId: targetTabId } : undefined
// Root-level Target.setAutoAttach must apply to all connected tabs since
// CDP auto-attach is per-debugger-session. Without this, OOPIF targets never attach.
if (msg.params.method === 'Target.setAutoAttach' && !msg.params.sessionId) {
const params = msg.params.params as Protocol.Target.SetAutoAttachRequest | undefined
if (!params) {
return {}
}
autoAttachParams = params
const connectedTabIds = Array.from(store.getState().tabs.entries())
.filter(([_, info]) => info.state === 'connected')
.map(([tabId]) => tabId)
await Promise.all(connectedTabIds.map(async (tabId) => {
try {
await chrome.debugger.sendCommand({ tabId }, 'Target.setAutoAttach', params)
} catch (error) {
logger.debug('Failed to set auto-attach for tab:', tabId, error)
}
}))
return {}
}
// TODO disable network things?
// if (msg.params.method === 'Network.enable' && msg.params.source !== 'playwriter') {
// logger.debug('Skipping Network.enable from non-playwriter CDP client:', msg.params.sessionId)
@@ -831,6 +858,15 @@ async function attachTab(tabId: number, { skipAttachedEvent = false }: { skipAtt
await chrome.debugger.sendCommand(debuggee, 'Page.enable')
// Reapply cached auto-attach for new tabs so OOPIF targets are reported immediately.
if (autoAttachParams) {
try {
await chrome.debugger.sendCommand(debuggee, 'Target.setAutoAttach', autoAttachParams)
} catch (error) {
logger.debug('Failed to apply auto-attach for tab:', tabId, error)
}
}
const contextMenuScript = `
document.addEventListener('contextmenu', (e) => {
window.__playwriter_lastRightClicked = e.target;
+6 -3
View File
@@ -1,5 +1,5 @@
import { fileURLToPath } from 'url';
import { dirname, resolve } from 'path';
import { fileURLToPath } from 'node:url';
import { dirname, resolve } from 'node:path';
import { defineConfig } from 'vite';
import { viteStaticCopy } from 'vite-plugin-static-copy';
@@ -13,6 +13,9 @@ if (process.env.TESTING) {
defineEnv['import.meta.env.TESTING'] = 'true';
}
// Allow tests to build per-port extension outputs to avoid parallel run conflicts.
const outDir = process.env.PLAYWRITER_EXTENSION_DIST || 'dist';
export default defineConfig({
plugins: [
viteStaticCopy({
@@ -48,7 +51,7 @@ export default defineConfig({
],
build: {
outDir: 'dist',
outDir,
emptyOutDir: false,
minify: false,
rollupOptions: {