add distinct icons for disconnected and restricted tab states

This commit is contained in:
Tommy D. Rossi
2025-12-18 15:43:50 +01:00
parent db4f7ef5a5
commit a2decc80e0
13 changed files with 34 additions and 7 deletions
Binary file not shown.

After

Width:  |  Height:  |  Size: 2.6 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 715 B

Binary file not shown.

After

Width:  |  Height:  |  Size: 962 B

Binary file not shown.

After

Width:  |  Height:  |  Size: 1.2 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 3.1 KiB

After

Width:  |  Height:  |  Size: 3.0 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 1.0 KiB

After

Width:  |  Height:  |  Size: 771 B

Binary file not shown.

Before

Width:  |  Height:  |  Size: 1.3 KiB

After

Width:  |  Height:  |  Size: 1.0 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 1.6 KiB

After

Width:  |  Height:  |  Size: 1.3 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 10 KiB

@@ -0,0 +1 @@
<svg xmlns="http://www.w3.org/2000/svg" width="424" height="424" fill="none" overflow="visible"><g><path d="M 0 212 C 0 112.063 0 62.095 31.037 31.037 C 62.116 0 112.063 0 212 0 C 311.937 0 361.905 0 392.942 31.037 C 424 62.116 424 112.063 424 212 C 424 311.937 424 361.905 392.942 392.942 C 361.926 424 311.937 424 212 424 C 112.063 424 62.095 424 31.037 392.942 C 0 361.926 0 311.937 0 212" fill="rgb(0, 0, 0)"></path><path d="M 225.732 260.521 L 277.905 312.673 C 283.311 318.1 286.003 320.793 289.014 322.043 C 293.042 323.718 297.557 323.718 301.585 322.043 C 304.596 320.793 307.309 318.1 312.694 312.694 C 318.1 307.288 320.793 304.596 322.043 301.585 C 323.722 297.563 323.722 293.036 322.043 289.014 C 320.793 286.003 318.1 283.29 312.694 277.905 L 260.521 225.732 L 276.442 209.789 C 292.766 193.465 300.907 185.325 298.999 176.548 C 297.07 167.792 286.237 163.785 264.591 155.814 L 192.384 129.208 C 149.2 113.308 127.618 105.358 116.488 116.488 C 105.358 127.618 113.308 149.2 129.208 192.384 L 155.814 264.591 C 163.785 286.237 167.792 297.07 176.548 298.999 C 185.303 300.928 193.465 292.766 209.789 276.442 Z" fill="rgb(255, 255, 255)"></path></g></svg>

After

Width:  |  Height:  |  Size: 1.1 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 9.8 KiB

@@ -0,0 +1 @@
<svg xmlns="http://www.w3.org/2000/svg" width="424" height="424" fill="none" overflow="visible"><g><path d="M 0 212 C 0 112.063 0 62.095 31.037 31.037 C 62.116 0 112.063 0 212 0 C 311.937 0 361.905 0 392.942 31.037 C 424 62.116 424 112.063 424 212 C 424 311.937 424 361.905 392.942 392.942 C 361.926 424 311.937 424 212 424 C 112.063 424 62.095 424 31.037 392.942 C 0 361.926 0 311.937 0 212" fill="rgb(136, 136, 136)"></path><path d="M 225.732 260.521 L 277.905 312.673 C 283.311 318.1 286.003 320.793 289.014 322.043 C 293.042 323.718 297.557 323.718 301.585 322.043 C 304.596 320.793 307.309 318.1 312.694 312.694 C 318.1 307.288 320.793 304.596 322.043 301.585 C 323.722 297.563 323.722 293.036 322.043 289.014 C 320.793 286.003 318.1 283.29 312.694 277.905 L 260.521 225.732 L 276.442 209.789 C 292.766 193.465 300.907 185.325 298.999 176.548 C 297.07 167.792 286.237 163.785 264.591 155.814 L 192.384 129.208 C 149.2 113.308 127.618 105.358 116.488 116.488 C 105.358 127.618 113.308 149.2 129.208 192.384 L 155.814 264.591 C 163.785 286.237 167.792 297.07 176.548 298.999 C 185.303 300.928 193.465 292.766 209.789 276.442 Z" fill="rgb(255, 255, 255)"></path></g></svg>

After

Width:  |  Height:  |  Size: 1.1 KiB

+32 -7
View File
@@ -626,6 +626,12 @@ async function resetDebugger(): Promise<void> {
} }
} }
function isRestrictedUrl(url: string | undefined): boolean {
if (!url) return true
const restrictedPrefixes = ['chrome://', 'chrome-extension://', 'devtools://', 'edge://']
return restrictedPrefixes.some((prefix) => url.startsWith(prefix))
}
const icons = { const icons = {
connected: { connected: {
path: { path: {
@@ -647,29 +653,40 @@ const icons = {
}, },
title: 'Connecting...', title: 'Connecting...',
badgeText: '...', badgeText: '...',
badgeColor: '#FF9800', badgeColor: [0, 0, 0, 0] as [number, number, number, number],
}, },
disconnected: { disconnected: {
path: {
'16': '/icons/icon-black-16.png',
'32': '/icons/icon-black-32.png',
'48': '/icons/icon-black-48.png',
'128': '/icons/icon-black-128.png',
},
title: 'Click to attach debugger',
badgeText: '',
badgeColor: [0, 0, 0, 0] as [number, number, number, number],
},
restricted: {
path: { path: {
'16': '/icons/icon-gray-16.png', '16': '/icons/icon-gray-16.png',
'32': '/icons/icon-gray-32.png', '32': '/icons/icon-gray-32.png',
'48': '/icons/icon-gray-48.png', '48': '/icons/icon-gray-48.png',
'128': '/icons/icon-gray-48.png', '128': '/icons/icon-gray-128.png',
}, },
title: 'Click to attach debugger', title: 'Cannot attach to this page',
badgeText: '', badgeText: '',
badgeColor: '#333333', badgeColor: [0, 0, 0, 0] as [number, number, number, number],
}, },
error: { error: {
path: { path: {
'16': '/icons/icon-gray-16.png', '16': '/icons/icon-gray-16.png',
'32': '/icons/icon-gray-32.png', '32': '/icons/icon-gray-32.png',
'48': '/icons/icon-gray-48.png', '48': '/icons/icon-gray-48.png',
'128': '/icons/icon-gray-48.png', '128': '/icons/icon-gray-128.png',
}, },
title: 'Error', title: 'Error',
badgeText: '!', badgeText: '!',
badgeColor: '#f44336', badgeColor: [0, 0, 0, 0] as [number, number, number, number],
}, },
} as const } as const
@@ -680,10 +697,12 @@ async function updateIcons(): Promise<void> {
const connectedCount = Array.from(tabs.values()).filter((t) => t.state === 'connected').length const connectedCount = Array.from(tabs.values()).filter((t) => t.state === 'connected').length
const allTabs = await chrome.tabs.query({}) const allTabs = await chrome.tabs.query({})
const tabUrlMap = new Map(allTabs.map((tab) => [tab.id, tab.url]))
const allTabIds = [undefined, ...allTabs.map((tab) => tab.id).filter((id): id is number => id !== undefined)] const allTabIds = [undefined, ...allTabs.map((tab) => tab.id).filter((id): id is number => id !== undefined)]
for (const tabId of allTabIds) { for (const tabId of allTabIds) {
const tabInfo = tabId !== undefined ? tabs.get(tabId) : undefined const tabInfo = tabId !== undefined ? tabs.get(tabId) : undefined
const tabUrl = tabId !== undefined ? tabUrlMap.get(tabId) : undefined
const iconConfig = (() => { const iconConfig = (() => {
if (connectionState === 'error') return icons.error if (connectionState === 'error') return icons.error
@@ -691,6 +710,7 @@ async function updateIcons(): Promise<void> {
if (tabInfo?.state === 'error') return icons.error if (tabInfo?.state === 'error') return icons.error
if (tabInfo?.state === 'connecting') return icons.connecting if (tabInfo?.state === 'connecting') return icons.connecting
if (tabInfo?.state === 'connected') return icons.connected if (tabInfo?.state === 'connected') return icons.connected
if (tabId !== undefined && isRestrictedUrl(tabUrl)) return icons.restricted
return icons.disconnected return icons.disconnected
})() })()
@@ -701,7 +721,7 @@ async function updateIcons(): Promise<void> {
})() })()
const badgeText = (() => { const badgeText = (() => {
if (iconConfig === icons.connected || iconConfig === icons.disconnected) { if (iconConfig === icons.connected || iconConfig === icons.disconnected || iconConfig === icons.restricted) {
return connectedCount > 0 ? String(connectedCount) : '' return connectedCount > 0 ? String(connectedCount) : ''
} }
return iconConfig.badgeText return iconConfig.badgeText
@@ -731,6 +751,11 @@ async function onActionClicked(tab: chrome.tabs.Tab): Promise<void> {
return return
} }
if (isRestrictedUrl(tab.url)) {
logger.debug('Cannot attach to restricted URL:', tab.url)
return
}
const { tabs, connectionState } = store.getState() const { tabs, connectionState } = store.getState()
const tabInfo = tabs.get(tab.id) const tabInfo = tabs.get(tab.id)