playwriter
Code Issues

fix: address PR review comments

Browse Source 
- Fix misleading comment about user gesture requirement in background.ts
- Remove unused 'target' variable in /recording/stop endpoint
- Fix /recording/cancel to not delete all recordings (handled by event)
- Remove redundant security middlewares (CORS handles it)
This commit is contained in:
Tommy D. Rossi
2026-01-25 17:01:04 +01:00
parent 050c6d5b50
commit c9e8361a54
2 changed files with 9 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files
extension/src/background.ts
+1 -1
View File
@@ -1110,7 +1110,7 @@ async function handleStartRecording(params: StartRecordingParams): Promise<Start
// Ensure offscreen document exists
await ensureOffscreenDocument()
// Get stream ID using chrome.tabCapture.getMediaStreamId (works without user gesture)
// Get stream ID using chrome.tabCapture.getMediaStreamId (requires activeTab permission - user must click extension icon)
const streamId = await new Promise<string>((resolve, reject) => {
chrome.tabCapture.getMediaStreamId({ targetTabId: tabId }, (id) => {
if (chrome.runtime.lastError) {