playwriter
Code Issues

Make wsUrl optional in getCDPSessionForPage, default to getCdpUrl()

Browse Source
This commit is contained in:
Tommy D. Rossi
2026-01-14 12:09:34 +01:00
parent e6d9cfe5e4
commit dcaaf68f1a
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
playwriter/src/cdp-session.ts
+4 -2
View File
@@ -2,6 +2,7 @@ import WebSocket from 'ws'
import type { Page } from 'playwright-core' import type { Page } from 'playwright-core'
import type { ProtocolMapping } from 'devtools-protocol/types/protocol-mapping.js' import type { ProtocolMapping } from 'devtools-protocol/types/protocol-mapping.js'
import type { CDPResponseBase, CDPEventBase } from './cdp-types.js' import type { CDPResponseBase, CDPEventBase } from './cdp-types.js'
import { getCdpUrl } from './utils.js'
/** /**
* Common interface for CDP sessions that works with both our CDPSession * Common interface for CDP sessions that works with both our CDPSession
@@ -162,8 +163,9 @@ export class CDPSession implements ICDPSession {
} }
} }
export async function getCDPSessionForPage({ page, wsUrl }: { page: Page; wsUrl: string }): Promise<CDPSession> { export async function getCDPSessionForPage({ page, wsUrl }: { page: Page; wsUrl?: string }): Promise<CDPSession> {
const ws = new WebSocket(wsUrl) const resolvedWsUrl = wsUrl || getCdpUrl()
const ws = new WebSocket(resolvedWsUrl)
await new Promise<void>((resolve, reject) => { await new Promise<void>((resolve, reject) => {
ws.on('open', resolve) ws.on('open', resolve)