playwriter
Code Issues

use page.on('popup') instead of page.opener() for popup detection

Browse Source 
page.opener() produced false positives during CDP reconnection because
existing pages re-enumerated via context.pages().forEach would sometimes
have a non-null opener. page.on('popup') only fires for actual
window.open() and target=_blank interactions, so it's safe to attach
on both new and existing pages without false positives.
This commit is contained in:
Tommy D. Rossi
2026-02-18 23:11:21 +01:00
parent 03a70fb9fe
commit ea4c66b2f5
1 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
playwriter/src/executor.ts
+16 -16
View File
@@ -312,20 +312,20 @@ export class PlaywrightExecutor {
} }
private setupPopupDetection(page: Page) { private setupPopupDetection(page: Page) {
// Check if this page was opened by window.open() (has an opener) // Listen for popup events (window.open, target=_blank) on each page.
const opener = page.opener() // This is more reliable than checking page.opener() on context 'page' event,
if (!opener) { // which also fires for context.newPage() and CDP reconnection scenarios.
return page.on('popup', (popup) => {
} const context = page.context()
const context = page.context() const pages = context.pages()
const pages = context.pages() const pageIndex = pages.indexOf(popup)
const pageIndex = pages.indexOf(page) const url = popup.url()
const url = page.url() this.popupWarnings.push(
this.popupWarnings.push( `Popup window detected (page index ${pageIndex}, url: ${url}). ` +
`Popup window detected (page index ${pageIndex}, url: ${url}). ` + `Popup windows cannot be controlled by playwriter. ` +
`Popup windows cannot be controlled by playwriter. ` + `Repeat the interaction in a way that does not open a popup, or navigate to the URL directly in a new tab.`,
`Repeat the interaction in a way that does not open a popup, or navigate to the URL directly in a new tab.`, )
) })
} }
private setupPageConsoleListener(page: Page) { private setupPageConsoleListener(page: Page) {
@@ -436,7 +436,7 @@ export class PlaywrightExecutor {
this.setupPageListeners(page) this.setupPageListeners(page)
}) })
context.pages().forEach((p) => this.setupPageConsoleListener(p)) context.pages().forEach((p) => this.setupPageListeners(p))
const page = await this.ensurePageForContext({ context, timeout: 10000 }) const page = await this.ensurePageForContext({ context, timeout: 10000 })
await this.preserveSystemColorScheme(context) await this.preserveSystemColorScheme(context)
@@ -511,7 +511,7 @@ export class PlaywrightExecutor {
this.setupPageListeners(page) this.setupPageListeners(page)
}) })
context.pages().forEach((p) => this.setupPageConsoleListener(p)) context.pages().forEach((p) => this.setupPageListeners(p))
const page = await this.ensurePageForContext({ context, timeout: 10000 }) const page = await this.ensurePageForContext({ context, timeout: 10000 })
await this.preserveSystemColorScheme(context) await this.preserveSystemColorScheme(context)