Treat reorder warnings as errors (#3944)

src/CMakeLists.txt

@@ -774,6 +774,7 @@ else ()
         -Wno-strict-aliasing
 
         -Werror=return-type
+        -Werror=reorder
     )
 
     if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")

src/providers/twitch/TwitchIrcServer.cpp

@@ -30,8 +30,8 @@ namespace chatterino {
 TwitchIrcServer::TwitchIrcServer()
     : whispersChannel(new Channel("/whispers", Channel::Type::TwitchWhispers))
     , mentionsChannel(new Channel("/mentions", Channel::Type::TwitchMentions))
-    , watchingChannel(Channel::getEmpty(), Channel::Type::TwitchWatching)
     , liveChannel(new Channel("/live", Channel::Type::TwitchLive))
+    , watchingChannel(Channel::getEmpty(), Channel::Type::TwitchWatching)
 {
     this->initializeIrc();
 

src/widgets/helper/ChannelView.cpp

@@ -122,8 +122,8 @@ namespace {
 
 ChannelView::ChannelView(BaseWidget *parent, Split *split, Context context)
     : BaseWidget(parent)
-    , scrollBar_(new Scrollbar(this))
     , split_(split)
+    , scrollBar_(new Scrollbar(this))
     , context_(context)
 {
     this->setMouseTracking(true);