Fix badge highlights using the same color (#3134)

Co-authored-by: Paweł <zneix@zneix.eu>

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## Unversioned
 
 - Bugfix: Moderation mode and active filters are now preserved when opening a split as a popup. (#3113, #3130)
+- Bugfix: Fixed a bug that caused all badge highlights to use the same color. (#3132, #3134)
 
 ## 2.3.4
 

src/widgets/settingspages/HighlightingPage.cpp

@@ -195,7 +195,7 @@ HighlightingPage::HighlightingPage()
                         }
                         getSettings()->highlightedBadges.append(HighlightBadge{
                             s->badgeName(), s->displayName(), false, false, "",
-                            ColorProvider::instance().color(
+                            *ColorProvider::instance().color(
                                 ColorType::SelfHighlight)});
                     }
                 });