chore: require clang-format 19 (#6236)

.github/workflows/check-formatting.yml

@@ -30,7 +30,7 @@ jobs:
         with:
           source: "./src ./tests/src ./benchmarks/src ./mocks/include"
           extensions: "hpp,cpp"
-          clangFormatVersion: 16
+          clangFormatVersion: 19
 
       - name: Check line-endings
         run: ./scripts/check-line-endings.sh

CHANGELOG.md

@@ -53,6 +53,7 @@
 - Dev: Fixed incorrect lua generation of static methods for typescript plugins. (#6190, #6223)
 - Dev: Merged top/bottom and left/right notebook layouts. (#6215)
 - Dev: Refactored `Button` and friends. (#6102)
+- Dev: Bumped clang-format requirement to 19. (#6236)
 
 ## 2.5.3
 

src/controllers/filters/lang/expressions/ListExpression.cpp

@@ -3,7 +3,7 @@
 namespace chatterino::filters {
 
 ListExpression::ListExpression(ExpressionList &&list)
-    : list_(std::move(list)){};
+    : list_(std::move(list)) {};
 
 QVariant ListExpression::execute(const ContextMap &context) const
 {

src/controllers/filters/lang/expressions/RegexExpression.cpp

@@ -7,7 +7,7 @@ RegexExpression::RegexExpression(const QString &regex, bool caseInsensitive)
     , caseInsensitive_(caseInsensitive)
     , regex_(QRegularExpression(
           regex, caseInsensitive ? QRegularExpression::CaseInsensitiveOption
-                                 : QRegularExpression::NoPatternOption)){};
+                                 : QRegularExpression::NoPatternOption)) {};
 
 QVariant RegexExpression::execute(const ContextMap & /*context*/) const
 {

src/util/CancellationToken.hpp

@@ -19,7 +19,7 @@ public:
 
     CancellationToken(const CancellationToken &) = default;
     CancellationToken(CancellationToken &&other) noexcept
-        : isCancelled_(std::move(other.isCancelled_)){};
+        : isCancelled_(std::move(other.isCancelled_)) {};
 
     /// @brief This destructor doesn't cancel the token
     ///
@@ -64,7 +64,7 @@ public:
 
     ScopedCancellationToken(const ScopedCancellationToken &) = delete;
     ScopedCancellationToken(ScopedCancellationToken &&other) noexcept
-        : backingToken_(std::move(other.backingToken_)){};
+        : backingToken_(std::move(other.backingToken_)) {};
 
     ~ScopedCancellationToken()
     {

src/util/IpcQueue.cpp

@@ -81,7 +81,7 @@ public:
 };
 
 IpcQueue::IpcQueue(IpcQueuePrivate *priv)
-    : private_(priv){};
+    : private_(priv) {};
 IpcQueue::~IpcQueue() = default;
 
 std::pair<std::unique_ptr<IpcQueue>, QString> IpcQueue::tryReplaceOrCreate(