Moved image uploader confirmation setting to external tools page (#2923)

src/widgets/settingspages/ExternalToolsPage.cpp

@@ -121,6 +121,9 @@ ExternalToolsPage::ExternalToolsPage()
 
         groupLayout->addRow(this->createCheckBox(
             "Enable image uploader", getSettings()->imageUploaderEnabled));
+        groupLayout->addRow(
+            this->createCheckBox("Ask for confirmation when uploading an image",
+                                 getSettings()->askOnImageUpload));
 
         groupLayout->addRow(
             "Request URL: ",

src/widgets/settingspages/GeneralPage.cpp

@@ -672,8 +672,6 @@ void GeneralPage::initLayout(GeneralPageView &layout)
         },
         false);
     layout.addCheckbox("Combine multiple bit tips into one", s.stackBits);
-    layout.addCheckbox("Ask for confirmation when uploading an image",
-                       s.askOnImageUpload);
     layout.addCheckbox("Messages in /mentions highlights tab",
                        s.highlightMentions);