revert: use max(minimum, min(bottom, value)) over clamp(..) (#5393)

CHANGELOG.md

@@ -10,7 +10,7 @@
 - Dev: Use Qt's high DPI scaling. (#4868)
 - Dev: Add doxygen build target. (#5377)
 - Dev: Make printing of strings in tests easier. (#5379)
-- Dev: Refactor and document `Scrollbar`. (#5334)
+- Dev: Refactor and document `Scrollbar`. (#5334, #5393)
 
 ## 2.5.1
 

src/widgets/Scrollbar.cpp

@@ -153,7 +153,9 @@ void Scrollbar::setPageSize(qreal value)
 
 void Scrollbar::setDesiredValue(qreal value, bool animated)
 {
-    value = std::clamp(value, this->minimum_, this->getBottom());
+    // this can't use std::clamp, because minimum_ < getBottom() isn't always
+    // true, which is a precondition for std::clamp
+    value = std::max(this->minimum_, std::min(this->getBottom(), value));
     if (areClose(this->currentValue_, value))
     {
         // value has not changed