Compare commits

..

1 Commits

Author SHA1 Message Date
ruinivist f76534b632 perf: optimize editorcanvas memoization and debounce shiki highlighting 2026-06-04 07:51:05 +00:00
3 changed files with 23 additions and 31 deletions
-4
View File
@@ -1,4 +0,0 @@
## 2023-10-27 - Excalidraw Component Re-render Performance Penalty
**Learning:** Due to the exceptionally high rendering cost of the `@excalidraw/excalidraw` canvas, inline functions passed as props (like `onChange` and `onExcalidrawAPI`) cause severe performance degradation by defeating `React.memo` and triggering full canvas re-renders when parent state changes.
**Action:** Always strictly memoize all callbacks passed to the Excalidraw component using `useCallback` to preserve prop stability and prevent unnecessary, expensive re-renders.
@@ -30,6 +30,8 @@ function CodeBlockEditor({
useEffect(() => { useEffect(() => {
let cancelled = false; let cancelled = false;
const timeoutId = setTimeout(() => {
void renderHighlightedCodeBlockHtml(draft.code, draft.language) void renderHighlightedCodeBlockHtml(draft.code, draft.language)
.then((nextHtml) => { .then((nextHtml) => {
if (!cancelled) { if (!cancelled) {
@@ -41,9 +43,11 @@ function CodeBlockEditor({
setHtml(null); setHtml(null);
} }
}); });
}, 100);
return () => { return () => {
cancelled = true; cancelled = true;
clearTimeout(timeoutId);
}; };
}, [draft.code, draft.language]); }, [draft.code, draft.language]);
+8 -16
View File
@@ -1,4 +1,4 @@
import { memo, useCallback } from "react"; import { memo } from "react";
import { Excalidraw } from "@excalidraw/excalidraw"; import { Excalidraw } from "@excalidraw/excalidraw";
import type { import type {
AppState, AppState,
@@ -7,7 +7,6 @@ import type {
ExcalidrawInitialDataState, ExcalidrawInitialDataState,
ExcalidrawProps, ExcalidrawProps,
} from "@excalidraw/excalidraw/types"; } from "@excalidraw/excalidraw/types";
import type { OrderedExcalidrawElement } from "@excalidraw/excalidraw/element/types";
import "../../../node_modules/@excalidraw/excalidraw/dist/prod/index.css"; import "../../../node_modules/@excalidraw/excalidraw/dist/prod/index.css";
import { type ScenePayload } from "../../core/shared"; import { type ScenePayload } from "../../core/shared";
import { import {
@@ -57,19 +56,6 @@ export const EditorCanvas = memo(function EditorCanvas({
onExcalidrawAPI, onExcalidrawAPI,
renderEmbeddable, renderEmbeddable,
}: EditorCanvasProps) { }: EditorCanvasProps) {
const handleChange = useCallback(
(
elements: readonly OrderedExcalidrawElement[],
appState: AppState,
files: BinaryFiles,
) => {
onEditorActivity();
onSceneChange(sceneFromEditor(elements, appState, files));
onSelectionStateChange(getCodeBlockSelectionState(elements, appState));
},
[onEditorActivity, onSceneChange, onSelectionStateChange],
);
if (loading || !scene) { if (loading || !scene) {
return <div className="editor-loading">{error ?? "Loading..."}</div>; return <div className="editor-loading">{error ?? "Loading..."}</div>;
} }
@@ -81,7 +67,13 @@ export const EditorCanvas = memo(function EditorCanvas({
initialData={sceneToInitialData(scene)} initialData={sceneToInitialData(scene)}
excalidrawAPI={onExcalidrawAPI} excalidrawAPI={onExcalidrawAPI}
renderEmbeddable={renderEmbeddable} renderEmbeddable={renderEmbeddable}
onChange={handleChange} onChange={(elements, appState, files) => {
onEditorActivity();
onSceneChange(sceneFromEditor(elements, appState, files));
onSelectionStateChange(
getCodeBlockSelectionState(elements, appState),
);
}}
/> />
</div> </div>
); );