perf: optimize editorcanvas memoization and debounce shiki highlighting

.jules/bolt.md

@@ -1,4 +0,0 @@
-## 2023-10-27 - Excalidraw Component Re-render Performance Penalty
-
-**Learning:** Due to the exceptionally high rendering cost of the `@excalidraw/excalidraw` canvas, inline functions passed as props (like `onChange` and `onExcalidrawAPI`) cause severe performance degradation by defeating `React.memo` and triggering full canvas re-renders when parent state changes.
-**Action:** Always strictly memoize all callbacks passed to the Excalidraw component using `useCallback` to preserve prop stability and prevent unnecessary, expensive re-renders.

src/client/components/CodeBlockSidebar.tsx

@@ -30,20 +30,24 @@ function CodeBlockEditor({
 
   useEffect(() => {
     let cancelled = false;
-    void renderHighlightedCodeBlockHtml(draft.code, draft.language)
+
-      .then((nextHtml) => {
+    const timeoutId = setTimeout(() => {
-        if (!cancelled) {
+      void renderHighlightedCodeBlockHtml(draft.code, draft.language)
-          setHtml(nextHtml);
+        .then((nextHtml) => {
-        }
+          if (!cancelled) {
-      })
+            setHtml(nextHtml);
-      .catch(() => {
+          }
-        if (!cancelled) {
+        })
-          setHtml(null);
+        .catch(() => {
-        }
+          if (!cancelled) {
-      });
+            setHtml(null);
+          }
+        });
+    }, 100);
 
     return () => {
       cancelled = true;
+      clearTimeout(timeoutId);
     };
   }, [draft.code, draft.language]);
 

src/client/components/EditorCanvas.tsx

@@ -1,4 +1,4 @@
-import { memo, useCallback } from "react";
+import { memo } from "react";
 import { Excalidraw } from "@excalidraw/excalidraw";
 import type {
   AppState,
@@ -7,7 +7,6 @@ import type {
   ExcalidrawInitialDataState,
   ExcalidrawProps,
 } from "@excalidraw/excalidraw/types";
-import type { OrderedExcalidrawElement } from "@excalidraw/excalidraw/element/types";
 import "../../../node_modules/@excalidraw/excalidraw/dist/prod/index.css";
 import { type ScenePayload } from "../../core/shared";
 import {
@@ -57,19 +56,6 @@ export const EditorCanvas = memo(function EditorCanvas({
   onExcalidrawAPI,
   renderEmbeddable,
 }: EditorCanvasProps) {
-  const handleChange = useCallback(
-    (
-      elements: readonly OrderedExcalidrawElement[],
-      appState: AppState,
-      files: BinaryFiles,
-    ) => {
-      onEditorActivity();
-      onSceneChange(sceneFromEditor(elements, appState, files));
-      onSelectionStateChange(getCodeBlockSelectionState(elements, appState));
-    },
-    [onEditorActivity, onSceneChange, onSelectionStateChange],
-  );
-
   if (loading || !scene) {
     return <div className="editor-loading">{error ?? "Loading..."}</div>;
   }
@@ -81,7 +67,13 @@ export const EditorCanvas = memo(function EditorCanvas({
         initialData={sceneToInitialData(scene)}
         excalidrawAPI={onExcalidrawAPI}
         renderEmbeddable={renderEmbeddable}
-        onChange={handleChange}
+        onChange={(elements, appState, files) => {
+          onEditorActivity();
+          onSceneChange(sceneFromEditor(elements, appState, files));
+          onSelectionStateChange(
+            getCodeBlockSelectionState(elements, appState),
+          );
+        }}
       />
     </div>
   );