feat: add http security headers to caddyfile

.jules/bolt.md

@@ -1,4 +0,0 @@
-## 2023-10-27 - Excalidraw Component Re-render Performance Penalty
-
-**Learning:** Due to the exceptionally high rendering cost of the `@excalidraw/excalidraw` canvas, inline functions passed as props (like `onChange` and `onExcalidrawAPI`) cause severe performance degradation by defeating `React.memo` and triggering full canvas re-renders when parent state changes.
-**Action:** Always strictly memoize all callbacks passed to the Excalidraw component using `useCallback` to preserve prop stability and prevent unnecessary, expensive re-renders.

.jules/sentinel.md

@@ -0,0 +1,4 @@
+## 2024-06-06 - Missing HTTP Security Headers
+**Vulnerability:** The Caddyfile configuration was missing standard HTTP security headers (X-Frame-Options, X-Content-Type-Options, Referrer-Policy), leaving the application susceptible to clickjacking, MIME-type sniffing, and sensitive data leakage via referrers.
+**Learning:** The application relies on Caddy as a reverse proxy, and by default, Caddy doesn't automatically add these specific security headers unless explicitly configured.
+**Prevention:** Ensure that reverse proxy configurations in new projects or updates to existing ones explicitly include essential HTTP security headers in a global scope to protect all served content.

Caddyfile

@@ -1,30 +1,36 @@
 {
-  auto_https off
+	auto_https off
-  admin off
+	admin off
 }
 
 :80 {
-  encode zstd gzip
+	encode zstd gzip
 
-  handle /mcp {
+	header {
-    reverse_proxy 127.0.0.1:3001
+		X-Frame-Options "SAMEORIGIN"
-  }
+		X-Content-Type-Options "nosniff"
+		Referrer-Policy "strict-origin-when-cross-origin"
+	}
 
-  @app path / /api/*
+	handle /mcp {
-  handle @app {
+		reverse_proxy 127.0.0.1:3001
-    reverse_proxy 127.0.0.1:3000
+	}
-  }
 
-  handle {
+	@app path / /api/*
-    root * /srv/public
+	handle @app {
+		reverse_proxy 127.0.0.1:3000
+	}
 
-    @html path /index.html /d/* /p/*
+	handle {
-    header @html Cache-Control "no-cache"
+		root * /srv/public
 
-    @assets path_regexp assets \.(?:css|js|mjs|svg|png|jpg|jpeg|gif|webp|ico|woff2?|ttf|otf)$
+		@html path /index.html /d/* /p/*
-    header @assets Cache-Control "public, max-age=31536000, immutable"
+		header @html Cache-Control "no-cache"
 
-    try_files {path} /index.html
+		@assets path_regexp assets \.(?:css|js|mjs|svg|png|jpg|jpeg|gif|webp|ico|woff2?|ttf|otf)$
-    file_server
+		header @assets Cache-Control "public, max-age=31536000, immutable"
-  }
+
+		try_files {path} /index.html
+		file_server
+	}
 }

src/client/App.tsx

@@ -307,10 +307,6 @@ function PrivateApp() {
     [],
   );
 
-  const handleExcalidrawAPI = useCallback((api: ExcalidrawImperativeAPI) => {
-    excalidrawApiRef.current = api;
-  }, []);
-
   return (
     <div className="app-shell" ref={appShellRef}>
       {toastMessage && (
@@ -336,7 +332,9 @@ function PrivateApp() {
           onSceneChange={handleSceneChange}
           onSelectionStateChange={handleCodeBlockSelectionChange}
           onEditorActivity={scheduleThemeTokenSync}
-          onExcalidrawAPI={handleExcalidrawAPI}
+          onExcalidrawAPI={(api) => {
+            excalidrawApiRef.current = api;
+          }}
           renderEmbeddable={renderCodeBlockEmbeddable}
         />
         <CodeBlockSidebar

src/client/components/EditorCanvas.tsx

@@ -1,4 +1,4 @@
-import { memo, useCallback } from "react";
+import { memo } from "react";
 import { Excalidraw } from "@excalidraw/excalidraw";
 import type {
   AppState,
@@ -7,7 +7,6 @@ import type {
   ExcalidrawInitialDataState,
   ExcalidrawProps,
 } from "@excalidraw/excalidraw/types";
-import type { OrderedExcalidrawElement } from "@excalidraw/excalidraw/element/types";
 import "../../../node_modules/@excalidraw/excalidraw/dist/prod/index.css";
 import { type ScenePayload } from "../../core/shared";
 import {
@@ -57,19 +56,6 @@ export const EditorCanvas = memo(function EditorCanvas({
   onExcalidrawAPI,
   renderEmbeddable,
 }: EditorCanvasProps) {
-  const handleChange = useCallback(
-    (
-      elements: readonly OrderedExcalidrawElement[],
-      appState: AppState,
-      files: BinaryFiles,
-    ) => {
-      onEditorActivity();
-      onSceneChange(sceneFromEditor(elements, appState, files));
-      onSelectionStateChange(getCodeBlockSelectionState(elements, appState));
-    },
-    [onEditorActivity, onSceneChange, onSelectionStateChange],
-  );
-
   if (loading || !scene) {
     return <div className="editor-loading">{error ?? "Loading..."}</div>;
   }
@@ -81,7 +67,13 @@ export const EditorCanvas = memo(function EditorCanvas({
         initialData={sceneToInitialData(scene)}
         excalidrawAPI={onExcalidrawAPI}
         renderEmbeddable={renderEmbeddable}
-        onChange={handleChange}
+        onChange={(elements, appState, files) => {
+          onEditorActivity();
+          onSceneChange(sceneFromEditor(elements, appState, files));
+          onSelectionStateChange(
+            getCodeBlockSelectionState(elements, appState),
+          );
+        }}
       />
     </div>
   );