fix: percent-encoded url for custom players (#6725)

Reviewed-by: Rasmus Karlsson <rasmus.karlsson@pajlada.com>

CHANGELOG.md

@@ -36,6 +36,7 @@
 - Bugfix: Forward query params to websocket URLs. (#6141)
 - Bugfix: Fixed Lua errors from handlers of HTTP requests not being logged. (#6452)
 - Bugfix: Fixed restore button not showing on Windows. (#6565)
+- Bugfix: Fixed custom player URIs for external players not always working due to URL percent-encoding. (#6725)
 - Bugfix: Fixed a crash that could occur when network requests were loading/saving cache as Chatterino was being shut down. (#6698)
 - Bugfix: Fixed popups and the overlay not being draggable on Wayland. (#6573)
 - Bugfix: Fixed middle-clicking usernames in a local channel opening an invalid viewercard. (#6577)

src/util/CustomPlayer.cpp

@@ -25,8 +25,9 @@ void openInCustomPlayer(QStringView channelName)
         return;
     }
 
-    QDesktopServices::openUrl(
-        QUrl{scheme % u"https://www.twitch.tv/" % channelName});
+    QString encodedTwitchUrl = QString::fromUtf8(
+        QUrl::toPercentEncoding(u"https://www.twitch.tv/" % channelName));
+    QDesktopServices::openUrl(QUrl{scheme % encodedTwitchUrl});
 }
 
 }  // namespace chatterino