Treat missing returns as errors

chatterino.pro

@@ -446,6 +446,8 @@ win32-msvc* {
     # Disabling strict-aliasing warnings for now, although we probably want to re-enable this in the future
     QMAKE_CXXFLAGS_WARN_ON += -Wno-strict-aliasing
 
+    QMAKE_CXXFLAGS_WARN_ON += -Werror=return-type
+
     equals(QMAKE_CXX, "clang++") {
         QMAKE_CXXFLAGS_WARN_ON += -Wno-unused-local-typedef
     } else {

src/providers/twitch/TwitchChannel.cpp

@@ -153,7 +153,7 @@ void TwitchChannel::sendMessage(const QString &message)
     // Do last message processing
     QString parsedMessage = app->emotes->emojis.replaceShortCodes(message);
 
-    parsedMessage = parsedMessage.trimmed();
+    parsedMessage.trim();
 
     if (parsedMessage.isEmpty()) {
         return;