chatterino2
Code Issues

Treat missing returns as errors

Browse Source
This commit is contained in:
Rasmus Karlsson
2018-07-07 10:38:56 +00:00
parent 256aabf746
commit cada32edfd
2 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
chatterino.pro
+2
View File
@@ -446,6 +446,8 @@ win32-msvc* {
# Disabling strict-aliasing warnings for now, although we probably want to re-enable this in the future # Disabling strict-aliasing warnings for now, although we probably want to re-enable this in the future
QMAKE_CXXFLAGS_WARN_ON += -Wno-strict-aliasing QMAKE_CXXFLAGS_WARN_ON += -Wno-strict-aliasing
QMAKE_CXXFLAGS_WARN_ON += -Werror=return-type
equals(QMAKE_CXX, "clang++") { equals(QMAKE_CXX, "clang++") {
QMAKE_CXXFLAGS_WARN_ON += -Wno-unused-local-typedef QMAKE_CXXFLAGS_WARN_ON += -Wno-unused-local-typedef
} else { } else {
src/providers/twitch/TwitchChannel.cpp
+1 -1
View File
@@ -153,7 +153,7 @@ void TwitchChannel::sendMessage(const QString &message)
// Do last message processing // Do last message processing
QString parsedMessage = app->emotes->emojis.replaceShortCodes(message); QString parsedMessage = app->emotes->emojis.replaceShortCodes(message);
parsedMessage = parsedMessage.trimmed(); parsedMessage.trim();
if (parsedMessage.isEmpty()) { if (parsedMessage.isEmpty()) {
return; return;